From: Richard Cochran <richardcochran@gmail.com>
To: Dong Zhu <bluezhudong@gmail.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Greg Rose <gregory.v.rose@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Alex Duyck <alexander.h.duyck@intel.com>,
John Ronciak <john.ronciak@intel.com>,
Tushar Dave <tushar.n.dave@intel.com>,
Matthew Vick <matthew.vick@intel.com>,
Jacob Keller <Jacob.e.keller@intel.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Dave Jones <davej@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] igb: add a method to get the nic hw time stamping policy
Date: Sun, 12 May 2013 19:24:46 +0200 [thread overview]
Message-ID: <20130512172446.GA2484@netboy> (raw)
In-Reply-To: <20130512142555.GI8399@zhudong.nay.redhat.com>
On Sun, May 12, 2013 at 10:25:55PM +0800, Dong Zhu wrote:
> Thanks for your pointing out my mistakes of CodingStyle.
>
> > > struct hwtstamp_config {
> > >+ int rw;
>
> My initial idea was that the type of rw should be enum like tx_type, but I am
> not sure whther it is necessary to define a new enum, if this patch could
> be accpeted I will ask someone about the rw. At that time I will change
> the type of rw to bool or define a new enum, then convert the if to
> switch if necessary.
You cannot add any new field at all. That would break a userland ABI.
Thanks,
Richard
next prev parent reply other threads:[~2013-05-12 17:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 14:02 [PATCH] igb: add a method to get the nic hw time stamping policy Dong Zhu
2013-05-11 15:31 ` Richard Cochran
2013-05-12 13:11 ` Dong Zhu
2013-05-11 16:51 ` Sergei Shtylyov
2013-05-12 14:25 ` Dong Zhu
2013-05-12 17:24 ` Richard Cochran [this message]
2013-05-13 2:12 ` Dong Zhu
2013-05-13 4:31 ` Richard Cochran
2013-05-13 10:07 ` Dong Zhu
2013-05-13 15:48 ` Vick, Matthew
2013-05-13 16:09 ` Ben Hutchings
2013-05-13 16:47 ` Keller, Jacob E
2013-05-14 9:51 ` Dong Zhu
2013-05-14 10:51 ` Peter P Waskiewicz Jr
2013-05-14 18:59 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130512172446.GA2484@netboy \
--to=richardcochran@gmail.com \
--cc=Jacob.e.keller@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bluezhudong@gmail.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tglx@linutronix.de \
--cc=tushar.n.dave@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox