From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martyn Welch <martyn.welch@ge.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
gmate.amit@gmail.com, devel@driverdev.osuosl.org,
manohar.vanga@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, yamanetoshi@gmail.com,
yongjun_wei@trendmicro.com.cn, joe@perches.com
Subject: Re: [PATCH] staging: vme: fix error return code in vme_user_probe()
Date: Mon, 13 May 2013 11:51:32 +0300 [thread overview]
Message-ID: <20130513085132.GI1360@mwanda> (raw)
In-Reply-To: <5190A140.3020306@ge.com>
On Mon, May 13, 2013 at 09:16:00AM +0100, Martyn Welch wrote:
> On 13/05/13 07:05, Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > Fix to return -ENOMEM in the resource alloc error handling
> > case instead of 0, as done elsewhere in this function.
> >
>
> Hi Wei,
>
> Thanks for your patch. As this is resource allocation rather than memory
> allocation that is failing, would -EAGAIN not make more sense than -ENOMEM?
>
ENOMEM is better. EAGAIN is for when trylock() fails etc. In other
words we are not allowed to block and someone is using the lock we
need.
It feels like we discuss error codes a lot on LKML and they should
be documented under Documententation/. The closest thing is
Documentation/i2c/fault-codes.
regards,
dan carpenter
next prev parent reply other threads:[~2013-05-13 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 6:05 [PATCH] staging: vme: fix error return code in vme_user_probe() Wei Yongjun
2013-05-13 8:16 ` Martyn Welch
2013-05-13 8:51 ` Dan Carpenter [this message]
2013-05-14 13:56 ` Martyn Welch
2013-05-14 14:19 ` Dan Carpenter
2013-05-15 7:56 ` Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513085132.GI1360@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn.welch@ge.com \
--cc=weiyj.lk@gmail.com \
--cc=yamanetoshi@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox