From: Andi Kleen <andi@firstfloor.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 1/2] perf report: Add --percent-limit option
Date: Mon, 13 May 2013 16:11:17 +0200 [thread overview]
Message-ID: <20130513141117.GC17814@two.firstfloor.org> (raw)
In-Reply-To: <1368434503-29373-1-git-send-email-namhyung@kernel.org>
On Mon, May 13, 2013 at 05:41:42PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> The --percent-limit option is for not showing small overheaded entries
> in the output. Maybe we want to set a certain default value like 0.1.
>
> Cc: Andi Kleen <andi@firstfloor.org>
I like the option, but 0 is not a good default.
Make it 1 or something.
Perhaps a better heuristic would be
percent < threshold || samples < sample-threshold
with sample-threshold being several hundred at least.
A very small number of hits on something is usually quite much useless,
unless your original event was extremly rare in the beginning
(but then it's unclear if the profile is any useful)
-Andi
next prev parent reply other threads:[~2013-05-13 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 8:41 [PATCH 1/2] perf report: Add --percent-limit option Namhyung Kim
2013-05-13 8:41 ` [PATCH 2/2] perf top: " Namhyung Kim
2013-05-13 8:58 ` Pekka Enberg
2013-05-13 8:58 ` [PATCH 1/2] perf report: " Pekka Enberg
2013-05-14 0:40 ` Namhyung Kim
2013-05-13 13:20 ` Jiri Olsa
2013-05-14 0:43 ` Namhyung Kim
2013-05-13 14:11 ` Andi Kleen [this message]
2013-05-14 0:56 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513141117.GC17814@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox