From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755525Ab3ENKqi (ORCPT ); Tue, 14 May 2013 06:46:38 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:42048 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755219Ab3ENKqg (ORCPT ); Tue, 14 May 2013 06:46:36 -0400 Date: Tue, 14 May 2013 11:46:31 +0100 From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Cc: arnd@arndb.de, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, devel@driverdev.osuosl.org Subject: Re: [PATCH 4/4] staging: =?utf-8?Q?ste=5Fr?= =?utf-8?Q?mi4=3A_Suppress_'ignoring_return_value_of_=E2=80=98regulator=5F?= =?utf-8?B?ZW5hYmxlKCkn?= warning Message-ID: <20130514104631.GA28781@gmail.com> References: <1367509690-24022-1-git-send-email-lee.jones@linaro.org> <1367509690-24022-5-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1367509690-24022-5-git-send-email-lee.jones@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: > In function ‘synaptics_rmi4_resume’: > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: > warning: ignoring return value of ‘regulator_enable’, declared > with attribute warn_unused_result [-Wunused-result > > Cc: Greg Kroah-Hartman > Cc: devel@driverdev.osuosl.org > Signed-off-by: Lee Jones > --- > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > index fe667dd..c4d013d 100644 > --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > @@ -1087,7 +1087,9 @@ static int synaptics_rmi4_resume(struct device *dev) > unsigned char intr_status; > struct synaptics_rmi4_data *rmi4_data = dev_get_drvdata(dev); > > - regulator_enable(rmi4_data->regulator); > + retval = regulator_enable(rmi4_data->regulator); > + if (retval < 0) > + return retval; > > enable_irq(rmi4_data->i2c_client->irq); > rmi4_data->touch_stopped = false; Are you planning to take this into the v3.10 -rcs? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog