From: Joerg Roedel <joro@8bytes.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: "Bjørn Mork" <bjorn@mork.no>,
"Paul E. McKenney" <paul.mckenney@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: Bisected post-3.9 regression: Resume takes 5 times as much time as with v3.9
Date: Tue, 14 May 2013 19:37:39 +0200 [thread overview]
Message-ID: <20130514173739.GH24440@8bytes.org> (raw)
In-Reply-To: <20130513140005.GA9165@linux.vnet.ibm.com>
Hi Paul,
On Mon, May 13, 2013 at 07:00:05AM -0700, Paul E. McKenney wrote:
> rcu: Fix comparison sense in rcu_needs_cpu()
>
> Commit c0f4dfd4f (rcu: Make RCU_FAST_NO_HZ take advantage of numbered
> callbacks) introduced a bug that can result in excessively long grace
> periods. This bug reverse the senes of the "if" statement checking
> for lazy callbacks, so that RCU takes a lazy approach when there are
> in fact non-lazy callbacks. This can result in excessive boot, suspend,
> and resume times.
>
> This commit therefore fixes the sense of this "if" statement.
>
> Reported-by: Borislav Petkov <bp@alien8.de>
> Reported-by: Bjørn Mork <bjorn@mork.no>
> Reported-by: Joerg Roedel <joro@8bytes.org>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Just tested the patch, it fixes the long boot delay for me. Thanks for
fixing this.
Tested-by: Joerg Roedel <joro@8bytes.org>
>
> diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
> index 641991d..63098a5 100644
> --- a/kernel/rcutree_plugin.h
> +++ b/kernel/rcutree_plugin.h
> @@ -1692,7 +1692,7 @@ int rcu_needs_cpu(int cpu, unsigned long *dj)
> rdtp->last_accelerate = jiffies;
>
> /* Request timer delay depending on laziness, and round. */
> - if (rdtp->all_lazy) {
> + if (!rdtp->all_lazy) {
> *dj = round_up(rcu_idle_gp_delay + jiffies,
> rcu_idle_gp_delay) - jiffies;
> } else {
>
next prev parent reply other threads:[~2013-05-14 17:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 18:04 Bisected post-3.9 regression: Resume takes 5 times as much time as with v3.9 Bjørn Mork
2013-05-12 11:31 ` Paul E. McKenney
2013-05-12 16:13 ` Bjørn Mork
2013-05-12 16:27 ` Borislav Petkov
2013-05-12 16:56 ` Bjørn Mork
2013-05-12 17:20 ` Borislav Petkov
2013-05-13 11:30 ` Rafael J. Wysocki
2013-05-13 12:00 ` [PATCH] hibernate: Correct documentation Borislav Petkov
2013-05-14 6:34 ` Rob Landley
2013-05-14 7:42 ` Borislav Petkov
2013-05-14 10:38 ` Bisected post-3.9 regression: Resume takes 5 times as much time as with v3.9 Paul E. McKenney
2013-05-12 18:29 ` Joerg Roedel
2013-05-12 20:57 ` Paul E. McKenney
2013-05-12 21:34 ` Joerg Roedel
2013-05-13 1:35 ` Paul E. McKenney
2013-05-13 6:00 ` Joerg Roedel
2013-05-13 14:00 ` Paul E. McKenney
2013-05-14 17:37 ` Joerg Roedel [this message]
2013-05-14 17:49 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514173739.GH24440@8bytes.org \
--to=joro@8bytes.org \
--cc=bjorn@mork.no \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.mckenney@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox