public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
	Steven Rostedt <srostedt@redhat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: V3.10-rc1 memory leak
Date: Tue, 14 May 2013 21:30:28 +0100	[thread overview]
Message-ID: <20130514203028.GA2997@MacBook-Pro.local> (raw)
In-Reply-To: <1368558586.6828.53.camel@gandalf.local.home>

Hi Steve,

On Tue, May 14, 2013 at 08:09:46PM +0100, Steven Rostedt wrote:
> # find /debug/tracing/events/ -name format |xargs grep ffff8800769f7438
> /debug/tracing/events/drm/drm_vblank_event_delivered/format:	field:pid_t pid;	offset:8;	size:4;	signed:1;ffff8800769f7438
> 
> Thus, what it is complaining about being leaked, is currently being
> used.
> 
> I guess it's because the fields are stored on the "event class"
> structure of the module. That is, the struct ftrace_event_class, which
> is part of the module data section:
> 
> struct ftrace_event_class {
>         char                    *system;
>         void                    *probe;
> #ifdef CONFIG_PERF_EVENTS
>         void                    *perf_probe;
> #endif
>         int                     (*reg)(struct ftrace_event_call *event,
>                                        enum trace_reg type, void *data);
>         int                     (*define_fields)(struct ftrace_event_call *);
>         struct list_head        *(*get_fields)(struct ftrace_event_call *);
>         struct list_head        fields;
>         int                     (*raw_init)(struct ftrace_event_call *);
> };
> 
> 
> The list_head fields holds the fields and these are used to print out
> the formats. For some reason, kmemleak is missing that the fields are
> being assigned to this list on module load.
> 
> Catalin, have any idea why kmemleak is not detecting that the field is
> being referenced?

I just got a patch today:

https://lkml.org/lkml/2013/5/10/607

which could be related. If Rusty doesn't push it I'll do. But please let
me know if it does not solve the problem.

Thanks.

-- 
Catalin

  reply	other threads:[~2013-05-14 20:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 17:39 V3.10-rc1 memory leak Larry Finger
2013-05-14 19:09 ` Steven Rostedt
2013-05-14 20:30   ` Catalin Marinas [this message]
2013-05-14 21:10     ` Larry Finger
2013-05-14 21:20       ` Steven Rostedt
2013-05-15  0:57         ` Steven Rostedt
2013-05-15  3:15           ` Larry Finger
2013-05-15 15:02             ` Catalin Marinas
2013-05-15 15:49               ` Toshi Kani
2013-05-15 16:47                 ` Catalin Marinas
2013-05-15 17:53                   ` Toshi Kani
2013-05-15 20:46               ` Larry Finger
2013-05-15 14:37           ` Catalin Marinas
2013-05-15 19:33             ` Steven Rostedt
2013-05-15 19:46               ` Steven Rostedt
2013-05-16 10:12               ` Catalin Marinas
2013-05-16 23:47                 ` Rusty Russell
2013-05-14 20:36   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130514203028.GA2997@MacBook-Pro.local \
    --to=catalin.marinas@arm.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox