From: Jens Axboe <axboe@kernel.dk>
To: Sam Bradshaw <sbradshaw@micron.com>
Cc: linux-kernel@vger.kernel.org, asamymuthupa@micron.com
Subject: Re: [PATCH] mtip32xx: Correctly handle bio->bi_idx != 0 conditions
Date: Wed, 15 May 2013 10:09:39 +0200 [thread overview]
Message-ID: <20130515080939.GD3276@kernel.dk> (raw)
In-Reply-To: <5192BB62.7090509@micron.com>
On Tue, May 14 2013, Sam Bradshaw wrote:
>
> Stacking drivers may append bvecs to existing bio's, resulting
> in non-zero bi_idx conditions. This patch counts the loops of
> bio_for_each_segment() rather than inheriting the bi_idx value
> to pass as a segment count to the hardware submission routine.
Yup, that's a plain bug. Iteration always starts at current index and
forward, so nents wont necessarily start at 0. Applied.
--
Jens Axboe
prev parent reply other threads:[~2013-05-15 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 22:32 [PATCH] mtip32xx: Correctly handle bio->bi_idx != 0 conditions Sam Bradshaw
2013-05-15 8:09 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130515080939.GD3276@kernel.dk \
--to=axboe@kernel.dk \
--cc=asamymuthupa@micron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox