* [PATCH] package: Makefile: unbreak binrpm-pkg target
@ 2013-05-15 16:06 Luiz Capitulino
2013-05-16 7:49 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Capitulino @ 2013-05-15 16:06 UTC (permalink / raw)
To: linux-kernel; +Cc: mmarek
Commit 6501320311664e11ad5489fedb17ea1f817c2617 dropped the rpm spec as a
prerequisite for the binrpm-pkg target but forgot to update $< usage,
which causes the rule to break.
This commit fixes that by replacing $< with the spec name.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
scripts/package/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index 84a4060..a4f31c9 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -63,7 +63,7 @@ binrpm-pkg: FORCE
mv -f $(objtree)/.tmp_version $(objtree)/.version
$(RPM) $(RPMOPTS) --define "_builddir $(objtree)" --target \
- $(UTS_MACHINE) -bb $<
+ $(UTS_MACHINE) -bb $(objtree)/binkernel.spec
rm binkernel.spec
# Deb target
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] package: Makefile: unbreak binrpm-pkg target
2013-05-15 16:06 [PATCH] package: Makefile: unbreak binrpm-pkg target Luiz Capitulino
@ 2013-05-16 7:49 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2013-05-16 7:49 UTC (permalink / raw)
To: Luiz Capitulino; +Cc: linux-kernel
On Wed, May 15, 2013 at 12:06:26PM -0400, Luiz Capitulino wrote:
> Commit 6501320311664e11ad5489fedb17ea1f817c2617 dropped the rpm spec as a
> prerequisite for the binrpm-pkg target but forgot to update $< usage,
> which causes the rule to break.
Oops :)
> This commit fixes that by replacing $< with the spec name.
Thanks for the fix, I added it to kbuild.git#rc-fixes.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-16 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 16:06 [PATCH] package: Makefile: unbreak binrpm-pkg target Luiz Capitulino
2013-05-16 7:49 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox