From: Don Zickus <dzickus@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/2] nohz: Disable LOCKUP_DETECTOR when NO_HZ_FULL is enabled
Date: Wed, 15 May 2013 13:50:17 -0400 [thread overview]
Message-ID: <20130515175017.GS23604@redhat.com> (raw)
In-Reply-To: <20130515171153.GF13916@laptop.home>
On Wed, May 15, 2013 at 07:11:53PM +0200, Peter Zijlstra wrote:
> On Wed, May 15, 2013 at 06:59:15PM +0200, Peter Zijlstra wrote:
> > On Wed, May 15, 2013 at 11:27:02AM -0400, Steven Rostedt wrote:
> > > Right now perf requires a tick, not sure exactly why, but you can look
> > > at the code in perf_event_task_tick(). Thus if NO_HZ_FULL sees that a
> > > perf tick is pending, it won't disable ticks. Unfortunately, the
> > > watchdogs, both NMI and soft lockup, use the perf infrastructure to
> > > trigger NMIs or interrupts. This adds a perf element on the rotate list
> > > and keeps NO_HZ_FULL from *ever* activating.
> > >
> >
> > Hmm.. Stephane had a bunch of patches converting the rotation thing to
> > an hrtimer. I seem to have forgotten what happened to them but I can't
> > seem to find them merged.
> >
> > I'll go look.
> >
> > That leaves the frequency stuff, but the watchdog doesn't use that.
> >
> > At which point we could run the watchdog without perf_event_task_tick().
>
> Found them:
>
> 1364991694-5876-1-git-send-email-eranian@google.com
>
> Looks like they were stuck in my inbox and never applied, so I just did.
> They should appear in tip soonish.
That was easy. Next problem! :-p
Thanks Peter!
Cheers,
Don
next prev parent reply other threads:[~2013-05-15 18:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 16:02 [GIT PULL] Nohz fixes Frederic Weisbecker
2013-05-14 16:02 ` [PATCH 1/2] nohz: Disable LOCKUP_DETECTOR when NO_HZ_FULL is enabled Frederic Weisbecker
2013-05-15 8:37 ` Peter Zijlstra
2013-05-15 15:06 ` Don Zickus
2013-05-15 15:27 ` Steven Rostedt
2013-05-15 16:26 ` Don Zickus
2013-05-15 16:59 ` Peter Zijlstra
2013-05-15 17:04 ` Steven Rostedt
2013-05-16 8:10 ` Peter Zijlstra
2013-05-16 11:38 ` Frederic Weisbecker
2013-05-16 17:57 ` Peter Zijlstra
2013-05-16 15:07 ` Paul E. McKenney
2013-05-16 17:56 ` Peter Zijlstra
2013-05-16 18:32 ` Steven Rostedt
2013-05-16 23:14 ` Frederic Weisbecker
2013-05-19 16:18 ` Paul E. McKenney
2013-05-16 20:06 ` Paul E. McKenney
2013-05-15 17:11 ` Peter Zijlstra
2013-05-15 17:50 ` Don Zickus [this message]
2013-05-15 16:55 ` Peter Zijlstra
2013-05-15 15:59 ` Frederic Weisbecker
2013-05-14 16:02 ` [PATCH 2/2] nohz: Warn if the machine can not perform nohz_full Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130515175017.GS23604@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox