public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: V3.10-rc1 memory leak
Date: Thu, 16 May 2013 11:12:00 +0100	[thread overview]
Message-ID: <20130516101200.GA3001@darko.cambridge.arm.com> (raw)
In-Reply-To: <1368646381.6828.74.camel@gandalf.local.home>

On Wed, May 15, 2013 at 08:33:01PM +0100, Steven Rostedt wrote:
> On Wed, 2013-05-15 at 15:37 +0100, Catalin Marinas wrote:
> 
> > >From 0621c7e1909ea86bf8499a0ffe5ea59d1007ee8c Mon Sep 17 00:00:00 2001
> > From: Catalin Marinas <catalin.marinas@arm.com>
> > Date: Wed, 15 May 2013 15:30:46 +0100
> > Subject: [PATCH] kmemleak: Scan the jump label module section
> > 
> > Objects allocated in jump_label_add_module() are currently reported as
> > leaks, though the pointers are stored in the module jump label section.
> > This patch informs kmemleak that this section needs to be scanned.
> > 
> > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> > Reported-by: Steven Rostedt <rostedt@goodmis.org>
> 
> This didn't work. I still get the leak messages. But this change did:
> 
> Instead of just picking data sections by name (names that start
> with .data, .bss or .ref.data), use the section flags and scan all
> sections that are allocated, writable and not executable. Which should
> cover all sections of a module that might reference data.
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

That's even better. I tested the two patches as well, added a subject
and a bit of clean-up and pushed them to this branch:

git://git.kernel.org/pub/scm/linux/kernel/git/cmarinas/linux-aarch64.git kmemleak

Rusty, are you ok to take these or just ack and I'll push them to Linus.

Thanks.

-- 
Catalin

  parent reply	other threads:[~2013-05-16 10:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 17:39 V3.10-rc1 memory leak Larry Finger
2013-05-14 19:09 ` Steven Rostedt
2013-05-14 20:30   ` Catalin Marinas
2013-05-14 21:10     ` Larry Finger
2013-05-14 21:20       ` Steven Rostedt
2013-05-15  0:57         ` Steven Rostedt
2013-05-15  3:15           ` Larry Finger
2013-05-15 15:02             ` Catalin Marinas
2013-05-15 15:49               ` Toshi Kani
2013-05-15 16:47                 ` Catalin Marinas
2013-05-15 17:53                   ` Toshi Kani
2013-05-15 20:46               ` Larry Finger
2013-05-15 14:37           ` Catalin Marinas
2013-05-15 19:33             ` Steven Rostedt
2013-05-15 19:46               ` Steven Rostedt
2013-05-16 10:12               ` Catalin Marinas [this message]
2013-05-16 23:47                 ` Rusty Russell
2013-05-14 20:36   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516101200.GA3001@darko.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox