From: Dan Carpenter <dan.carpenter@oracle.com>
To: KY Srinivasan <kys@microsoft.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"ohering@suse.com" <ohering@suse.com>,
"jbottomley@parallels.com" <jbottomley@parallels.com>,
"hch@infradead.org" <hch@infradead.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>
Subject: Re: [PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS
Date: Thu, 16 May 2013 17:08:16 +0300 [thread overview]
Message-ID: <20130516140816.GY30128@mwanda> (raw)
In-Reply-To: <fe60584bb8f2485abebffab2d0e8722d@SN2PR03MB061.namprd03.prod.outlook.com>
On Thu, May 16, 2013 at 02:01:12PM +0000, KY Srinivasan wrote:
> > Would the right fix be to add some sanity checks in module_init()?
>
> The check is already there (as I noted above). Look at the function:
> storvsc_drv_init(). If the ring size is picked incorrectly, the load is failed.
>
Ah. I see that now. My mistake.
regards,
dan carpenter
next prev parent reply other threads:[~2013-05-16 14:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 12:19 [PATCH V1 0/7] Drivers: hv/scsi: Implement multi-channel support K. Y. Srinivasan
2013-05-16 12:21 ` [PATCH V1 1/7] Drivers: hv: vmbus: " K. Y. Srinivasan
2013-05-16 12:21 ` [PATCH V1 2/7] Drivers: hv: Add the GUID fot synthetic fiber channel device K. Y. Srinivasan
2013-05-16 14:00 ` Greg KH
2013-05-16 12:21 ` [PATCH V1 3/7] Drivers: scsi: storvsc: Make the scsi timeout a module parameter K. Y. Srinivasan
2013-05-16 12:21 ` [PATCH V1 4/7] Drivers: scsi: storvsc: Update the storage protocol to win8 level K. Y. Srinivasan
2013-05-16 12:21 ` [PATCH V1 5/7] Drivers: scsi: storvsc: Implement multi-channel support K. Y. Srinivasan
2013-05-16 12:21 ` [PATCH V1 6/7] Drivers: scsi: storvsc: Support FC devices K. Y. Srinivasan
2013-05-16 12:21 ` [PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS K. Y. Srinivasan
2013-05-16 12:02 ` Dan Carpenter
2013-05-16 13:37 ` KY Srinivasan
2013-05-16 13:55 ` Dan Carpenter
2013-05-16 14:01 ` KY Srinivasan
2013-05-16 14:08 ` Dan Carpenter [this message]
2013-05-16 14:01 ` [PATCH V1 1/7] Drivers: hv: vmbus: Implement multi-channel support Greg KH
2013-05-23 17:26 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516140816.GY30128@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jbottomley@parallels.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ohering@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox