From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754334Ab3EPOJK (ORCPT ); Thu, 16 May 2013 10:09:10 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:17627 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115Ab3EPOJF (ORCPT ); Thu, 16 May 2013 10:09:05 -0400 Date: Thu, 16 May 2013 17:08:16 +0300 From: Dan Carpenter To: KY Srinivasan Cc: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "ohering@suse.com" , "jbottomley@parallels.com" , "hch@infradead.org" , "linux-scsi@vger.kernel.org" , "apw@canonical.com" , "jasowang@redhat.com" Subject: Re: [PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS Message-ID: <20130516140816.GY30128@mwanda> References: <1368706784-32276-1-git-send-email-kys@microsoft.com> <1368706879-32321-1-git-send-email-kys@microsoft.com> <1368706879-32321-7-git-send-email-kys@microsoft.com> <20130516120200.GN1360@mwanda> <797ed8d967414124a00ee151077c70fa@SN2PR03MB061.namprd03.prod.outlook.com> <20130516135528.GX30128@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 16, 2013 at 02:01:12PM +0000, KY Srinivasan wrote: > > Would the right fix be to add some sanity checks in module_init()? > > The check is already there (as I noted above). Look at the function: > storvsc_drv_init(). If the ring size is picked incorrectly, the load is failed. > Ah. I see that now. My mistake. regards, dan carpenter