From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@iki.fi>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, balbi@ti.com
Subject: Re: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy
Date: Thu, 16 May 2013 08:58:57 -0700 [thread overview]
Message-ID: <20130516155857.GV5600@atomide.com> (raw)
In-Reply-To: <51936946.3030507@iki.fi>
* Tomi Valkeinen <tomi.valkeinen@iki.fi> [130515 03:59]:
> On 23/04/13 09:14, Kishon Vijay Abraham I wrote:
> > After the device names are created using PLATFORM_DEVID_AUTO, the old
> > device names given in usb_bind_phy are no longer valid causing the musb
> > controller not to get the phy reference. Updated the usb_bind_phy with
> > the new device names to get MUSB functional in omap4 panda.
> >
> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> > Tested in OMAP4 PANDA.
> > arch/arm/mach-omap2/board-4430sdp.c | 2 +-
> > arch/arm/mach-omap2/board-omap4panda.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> > index 00d7290..56a9a4f 100644
> > --- a/arch/arm/mach-omap2/board-4430sdp.c
> > +++ b/arch/arm/mach-omap2/board-4430sdp.c
> > @@ -730,7 +730,7 @@ static void __init omap_4430sdp_init(void)
> > omap4_sdp4430_wifi_init();
> > omap4_twl6030_hsmmc_init(mmc);
> >
> > - usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto");
> > + usb_bind_phy("musb-hdrc.2.auto", 0, "omap-usb2.3.auto");
> > usb_musb_init(&musb_board_data);
> >
> > status = omap_ethernet_init();
>
> I'm seeing
>
> [ 2.190155] unable to find transceiver
> [ 2.190155] HS USB OTG: no transceiver configured
> [ 2.190155] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed
> with status -517
> [ 2.207458] platform musb-hdrc.0.auto: Driver musb-hdrc requests
> probe deferral
>
> on 4430sdp with v3.10-rc1. Does that mean that the musb-hdrc.0.auto was
> indeed correct, and the new value of musb-hdrc.2.auto is not?
Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds
like the some transceivers should depend on that for omap4.
> The musb-hdrc id is wrong on overo also.
Hmm has there been a fix posted for that?
Regards,
Tony
next prev parent reply other threads:[~2013-05-16 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 6:14 [PATCH] ARM: OMAP4: change the device names in usb_bind_phy Kishon Vijay Abraham I
2013-04-23 17:36 ` Tony Lindgren
2013-05-15 10:53 ` Tomi Valkeinen
2013-05-16 15:58 ` Tony Lindgren [this message]
2013-05-16 16:05 ` Tomi Valkeinen
2013-05-16 16:20 ` Tony Lindgren
2013-05-17 5:39 ` Kishon Vijay Abraham I
2013-05-17 17:23 ` Tony Lindgren
2013-05-21 12:08 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516155857.GV5600@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tomi.valkeinen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox