From: Tejun Heo <tj@kernel.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/workqueue.c: need call device_remove_file() when failure occurs after called device_create_file()
Date: Thu, 16 May 2013 10:50:17 -0700 [thread overview]
Message-ID: <20130516175017.GA7171@mtj.dyndns.org> (raw)
In-Reply-To: <5194652B.4010209@asianux.com>
Hey,
On Thu, May 16, 2013 at 12:48:43PM +0800, Chen Gang wrote:
> __sysfs_remove_dir() remove all related things, but not deref the count.
>
> For __sysfs_remove_dir() ->
> ...
> sysfs_addrm_start()
> ...
> while() {
> ...
> sysfs_remove_one() (not deref the related file)
> }
> sysfs_addrm_finish() (will deref current dir)
>
> For device_remove_file() ->
> sysfs_remove_file() ->
> sysfs_hash_and_remove() ->
> ...
> sysfs_addrm_start()
> ...
> sysfs_remove_one() (not deref the current file)
> sysfs_addrm_finish() (will deref current file)
>
>
> So if not call device_remove_file() firstly, the all files under the
> directory are removed, but the related resources are not released which
> will cause resource leak.
Can you please be more specific on what gets leaked and if possible
fix it from sysfs side?
Thanks.
--
tejun
next prev parent reply other threads:[~2013-05-16 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 12:25 [PATCH] kernel/workqueue.c: better to free related resources when failure occurs in wq_numa_init() Chen Gang
2013-05-14 15:17 ` Tejun Heo
2013-05-15 2:16 ` Chen Gang
2013-05-15 6:13 ` [PATCH] kernel/workqueue.c: need call device_remove_file() when failure occurs after called device_create_file() Chen Gang
2013-05-15 21:22 ` Tejun Heo
2013-05-16 3:33 ` Chen Gang
2013-05-16 4:16 ` Chen Gang
2013-05-16 4:48 ` Chen Gang
2013-05-16 17:50 ` Tejun Heo [this message]
2013-05-17 2:51 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516175017.GA7171@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox