From: Vivek Goyal <vgoyal@redhat.com>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: ebiederm@xmission.com, akpm@linux-foundation.org, cpw@sgi.com,
kumagai-atsushi@mxc.nes.nec.co.jp, lisa.mitchell@hp.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
zhangyanfei@cn.fujitsu.com, jingbai.ma@hp.com,
linux-mm@kvack.org, riel@redhat.com, walken@google.com,
hughd@google.com, kosaki.motohiro@jp.fujitsu.com
Subject: Re: [PATCH v6 6/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory
Date: Thu, 16 May 2013 16:32:36 -0400 [thread overview]
Message-ID: <20130516203236.GG5904@redhat.com> (raw)
In-Reply-To: <20130515090614.28109.26492.stgit@localhost6.localdomain6>
On Wed, May 15, 2013 at 06:06:14PM +0900, HATAYAMA Daisuke wrote:
[..]
> +static int __init get_note_number_and_size_elf32(const Elf32_Ehdr *ehdr_ptr,
> + int *nr_ptnote, u64 *phdr_sz)
> +{
> + return process_note_headers_elf32(ehdr_ptr, nr_ptnote, phdr_sz, NULL);
> +}
> +
> +static int __init copy_notes_elf32(const Elf32_Ehdr *ehdr_ptr, char *notes_buf)
> +{
> + return process_note_headers_elf32(ehdr_ptr, NULL, NULL, notes_buf);
> +}
> +
Please don't do this. We need to create two separate functions doing
two different operations and not just create wrapper around a function
which does two things.
I know both functions will have similar for loops for going through
the elf notes but it is better then doing function overloading based
on parameters passed.
Vivek
next prev parent reply other threads:[~2013-05-16 20:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 9:05 [PATCH v6 0/8] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-15 9:05 ` [PATCH v6 1/8] vmcore: clean up read_vmcore() HATAYAMA Daisuke
2013-05-15 9:33 ` Zhang Yanfei
2013-05-15 9:05 ` [PATCH v6 2/8] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke
2013-05-16 5:58 ` Zhang Yanfei
2013-05-16 16:51 ` Vivek Goyal
2013-05-17 0:08 ` HATAYAMA Daisuke
2013-05-15 9:05 ` [PATCH v6 3/8] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list HATAYAMA Daisuke
2013-05-16 5:59 ` Zhang Yanfei
2013-05-15 9:06 ` [PATCH v6 4/8] vmalloc: make find_vm_area check in range HATAYAMA Daisuke
2013-05-15 21:37 ` KOSAKI Motohiro
2013-05-16 23:45 ` HATAYAMA Daisuke
2013-05-15 9:06 ` [PATCH v6 5/8] vmalloc: introduce remap_vmalloc_range_partial HATAYAMA Daisuke
2013-05-15 9:06 ` [PATCH v6 6/8] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory HATAYAMA Daisuke
2013-05-16 7:19 ` Zhang Yanfei
2013-05-16 20:32 ` Vivek Goyal [this message]
2013-05-16 23:47 ` HATAYAMA Daisuke
2013-05-15 9:06 ` [PATCH v6 7/8] vmcore: calculate vmcore file size from buffer size and total size of vmcore objects HATAYAMA Daisuke
2013-05-16 7:19 ` Zhang Yanfei
2013-05-15 9:06 ` [PATCH v6 8/8] vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-05-16 7:25 ` Zhang Yanfei
2013-05-16 20:44 ` Vivek Goyal
2013-05-17 0:06 ` [PATCH v6 0/8] kdump, " H. Peter Anvin
2013-05-17 1:45 ` HATAYAMA Daisuke
2013-05-17 2:53 ` Eric W. Biederman
2013-05-17 3:21 ` H. Peter Anvin
2013-05-17 4:29 ` Eric W. Biederman
2013-05-17 5:43 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516203236.GG5904@redhat.com \
--to=vgoyal@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=jingbai.ma@hp.com \
--cc=kexec@lists.infradead.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lisa.mitchell@hp.com \
--cc=riel@redhat.com \
--cc=walken@google.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox