From: Robert Richter <rric@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Boyer <jwboyer@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
x86@kernel.org, linux-kernel@vger.kernel.org, gleb@redhat.com
Subject: Re: Drop WARN on AMD lack of perfctrs
Date: Thu, 16 May 2013 22:55:58 +0200 [thread overview]
Message-ID: <20130516205558.GE8356@rric.localhost> (raw)
In-Reply-To: <20130516181018.GO19669@dyad.programming.kicks-ass.net>
On 16.05.13 20:10:18, Peter Zijlstra wrote:
> On Thu, May 16, 2013 at 01:55:57PM -0400, Josh Boyer wrote:
> > Maybe. But do you really need to dump a stack trace here? What is a
> > user supposed to do with that information? Can they fix the kernel?
> > Can the fix the CPU? As far as I can tell, they can't do either.
>
> Send their CPU back to AMD is I suppose the best they can do ;-)
>
> > Is using pr_err with the same message really somehow worse than using
> > WARN?
>
> I would make it a FW_BUG as well. But yeah, I suppose that is a better option
> than the WARN_ON. Unless Robert had a different reason...
iirc the reason was the different msr range that is switched on fam15h
with a different counter to counter msr offset of 2 instead of 1. The
code relies on the assumption that the msrs exist on that cpu. Thus
the warning if not. Also note that code may have changed in 3.10 in
that area.
-Robert
next prev parent reply other threads:[~2013-05-16 20:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 15:10 Drop WARN on AMD lack of perfctrs Josh Boyer
2013-05-16 17:51 ` Peter Zijlstra
2013-05-16 17:55 ` Josh Boyer
2013-05-16 18:10 ` Peter Zijlstra
2013-05-16 20:55 ` Robert Richter [this message]
2013-05-16 21:34 ` Borislav Petkov
2013-05-17 9:04 ` Peter Zijlstra
2013-05-17 9:16 ` Borislav Petkov
2013-05-17 9:27 ` Peter Zijlstra
2013-05-17 9:45 ` Borislav Petkov
2013-05-17 10:36 ` Robert Richter
2013-05-17 10:57 ` Peter Zijlstra
2013-05-21 8:56 ` Robert Richter
2013-05-21 11:05 ` Peter Zijlstra
2013-05-21 13:58 ` Robert Richter
2013-05-21 15:20 ` Jacob Shin
2013-05-28 13:03 ` [tip:perf/core] perf/x86/amd: Rework AMD PMU init code tip-bot for Peter Zijlstra
2013-05-16 21:54 ` Drop WARN on AMD lack of perfctrs Josh Boyer
2013-05-16 22:33 ` Robert Richter
2013-05-16 19:31 ` Gleb Natapov
2013-05-16 20:00 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516205558.GE8356@rric.localhost \
--to=rric@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=gleb@redhat.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).