* [PATCH] Staging: Goldfish: goldfish_nand: Fixed all checkpatch errors
@ 2013-05-04 16:55 jake.champlin.27
2013-05-16 23:06 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: jake.champlin.27 @ 2013-05-04 16:55 UTC (permalink / raw)
To: gregkh, yunhong.jiang, sheng, mikechan, xiaohui.xin; +Cc: linux-kernel, devel
>From 37830ddd9548d298c0c846cd36181cdb97ceebd7 Mon Sep 17 00:00:00 2001
From: Jake Champlin <jake.champlin.27@gmail.com>
Date: Sat, 4 May 2013 12:50:27 -0400
Subject: [PATCH] Staging: Goldfish: goldfish_nand: Fixed all checkpatch errors
Fixed all checkpatch errors included inside goldfish_nand.c.
Checkpatch is now clean for goldfish_nand.c
Signed-off-by: "Jake Champlin" <jake.champlin.27@gmail.com>
---
drivers/staging/goldfish/goldfish_nand.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c
index ab1f019..81e2ad4 100644
--- a/drivers/staging/goldfish/goldfish_nand.c
+++ b/drivers/staging/goldfish/goldfish_nand.c
@@ -326,9 +326,10 @@ static int goldfish_nand_init_device(struct platform_device *pdev,
(mtd->writesize + mtd->oobsize) * mtd->writesize;
do_div(mtd->size, mtd->writesize + mtd->oobsize);
mtd->size *= mtd->writesize;
- dev_dbg(&pdev->dev,
+ dev_dbg(&pdev->dev,
"goldfish nand dev%d: size %llx, page %d, extra %d, erase %d\n",
- id, mtd->size, mtd->writesize, mtd->oobsize, mtd->erasesize);
+ id, mtd->size, mtd->writesize,
+ mtd->oobsize, mtd->erasesize);
spin_unlock_irqrestore(&nand->lock, irq_flags);
mtd->priv = nand;
@@ -340,7 +341,7 @@ static int goldfish_nand_init_device(struct platform_device *pdev,
result = goldfish_nand_cmd(mtd, NAND_CMD_GET_DEV_NAME, 0, name_len,
name);
if (result != name_len) {
- dev_err(&pdev->dev,
+ dev_err(&pdev->dev,
"goldfish_nand_init_device failed to get dev name %d != %d\n",
result, name_len);
return -ENODEV;
@@ -391,7 +392,7 @@ static int goldfish_nand_probe(struct platform_device *pdev)
version = readl(base + NAND_VERSION);
if (version != NAND_VERSION_CURRENT) {
- dev_err(&pdev->dev,
+ dev_err(&pdev->dev,
"goldfish_nand_init: version mismatch, got %d, expected %d\n",
version, NAND_VERSION_CURRENT);
return -ENODEV;
@@ -400,7 +401,7 @@ static int goldfish_nand_probe(struct platform_device *pdev)
if (num_dev == 0)
return -ENODEV;
- nand = devm_kzalloc(&pdev->dev, sizeof(*nand) +
+ nand = devm_kzalloc(&pdev->dev, sizeof(*nand) +
sizeof(struct mtd_info) * num_dev, GFP_KERNEL);
if (nand == NULL)
return -ENOMEM;
--
1.8.2.1
--
Jake Champlin
jake.champlin.27@gmail.com
<MuttClient>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: Goldfish: goldfish_nand: Fixed all checkpatch errors
2013-05-04 16:55 [PATCH] Staging: Goldfish: goldfish_nand: Fixed all checkpatch errors jake.champlin.27
@ 2013-05-16 23:06 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-05-16 23:06 UTC (permalink / raw)
To: jake.champlin.27
Cc: yunhong.jiang, sheng, mikechan, xiaohui.xin, devel, linux-kernel
On Sat, May 04, 2013 at 12:55:12PM -0400, jake.champlin.27@gmail.com wrote:
> From: Jake Champlin <jake.champlin.27@gmail.com>
>
> Fixed all checkpatch errors included inside goldfish_nand.c.
> Checkpatch is now clean for goldfish_nand.c
>
> Signed-off-by: "Jake Champlin" <jake.champlin.27@gmail.com>
Can you respin this against linux-next as it doesn't seem to apply to my
tree at all.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-17 3:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-04 16:55 [PATCH] Staging: Goldfish: goldfish_nand: Fixed all checkpatch errors jake.champlin.27
2013-05-16 23:06 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox