public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Libo Chen <libo.chen@huawei.com>
Cc: Sonic.Zhang@analog.com, uclinux-dist-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	lizefan@huawei.com
Subject: Re: [PATCH v2 0/2] i2c: fix two wrong mem release
Date: Fri, 17 May 2013 11:43:04 +0200	[thread overview]
Message-ID: <20130517094301.GH17056@katana> (raw)
In-Reply-To: <1368088044-20408-1-git-send-email-libo.chen@huawei.com>

On Thu, May 09, 2013 at 04:27:22PM +0800, Libo Chen wrote:
> fix two wrong mem release
> 
> * Changelog from v1:
>   * exchange out_error_no_irq and out_error_pin_mux  suggested by Sonic <Sonic.Zhang@analog.com>  
>   * add some new tag , make code cleanly

Thanks for the submission. I do think the proper solution would be to
convert the drivers to use the devm_* mechanisms, though. You can check
commit 857968434bb6dbda0911f38ec46b0c3d0c963771 ("i2c: davinci: update
to devm_* API") as a reference.

Thanks,

   Wolfram

  parent reply	other threads:[~2013-05-17  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09  8:27 [PATCH v2 0/2] i2c: fix two wrong mem release Libo Chen
2013-05-09  8:27 ` [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful Libo Chen
2013-05-09  8:31   ` Zhang, Sonic
2013-05-09  8:33   ` Zhang, Sonic
2013-05-10  1:01     ` Libo Chen
2013-05-13  8:52       ` Zhang, Sonic
2013-05-09  8:34   ` Zhang, Sonic
2013-05-09  8:27 ` [PATCH v2 2/2] i2c: pxa: no need release_mem_region before request_mem_region successful Libo Chen
2013-05-17  9:43 ` Wolfram Sang [this message]
2013-05-19  2:13   ` [PATCH v2 0/2] i2c: fix two wrong mem release Libo Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130517094301.GH17056@katana \
    --to=wsa@the-dreams.de \
    --cc=Sonic.Zhang@analog.com \
    --cc=libo.chen@huawei.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox