public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Holler <holler@ahsoftware.de>
Cc: linux-kernel@vger.kernel.org,
	Peter Hurley <peter@hurleysoftware.com>,
	Jiri Slaby <jslaby@suse.cz>,
	stable@vger.kernel.org
Subject: Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty
Date: Fri, 17 May 2013 08:31:36 -0700	[thread overview]
Message-ID: <20130517153136.GC19541@kroah.com> (raw)
In-Reply-To: <1368774728-4817-1-git-send-email-holler@ahsoftware.de>

On Fri, May 17, 2013 at 09:12:08AM +0200, Alexander Holler wrote:
> tty depends on tty_port until tty_release() was called. Make sure a BUG
> will be hit, if tty_port will be destroyed before tty.

So you want to ensure that we crash a machine?  No, please never add
BUG() statements to the kernel, unless something _really_ bad is going
to happen if we don't call it.  I never want to stop a machine from
running, do you?

I can't take this as-is, why not just fix the root problem?

thanks,

greg k-h

  reply	other threads:[~2013-05-17 15:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16  6:45 BUG: tty: memory corruption through tty_release/tty_ldisc_release Alexander Holler
2013-05-16 13:15 ` Alexander Holler
2013-05-16 13:47 ` Peter Hurley
2013-05-16 13:59   ` Alexander Holler
2013-05-16 21:53     ` Peter Hurley
2013-05-17  4:43       ` Alexander Holler
2013-05-17  7:12         ` [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty Alexander Holler
2013-05-17 15:31           ` Greg Kroah-Hartman [this message]
2013-05-17 16:41             ` Alexander Holler
2013-05-17 18:06               ` Peter Hurley
2013-05-17 19:22                 ` Alexander Holler
2013-05-17 19:43                   ` Alexander Holler
2013-05-17 22:51                     ` Peter Hurley
2013-05-17 23:41                       ` Alexander Holler
2013-06-25 14:18         ` BUG: tty: memory corruption through tty_release/tty_ldisc_release Dean Jenkins
2013-06-26  7:23           ` Alexander Holler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130517153136.GC19541@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=holler@ahsoftware.de \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox