Re: [PATCH] Finally eradicate CONFIG_HOTPLUG

Peter Stuge
2013-05-21T10:20:35Z

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

Are you changing the code to have HOTPLUG always -on- or -off- ?

From the commit message I had expected always -on-.

Stephen Rothwell wrote:
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -68,14 +68,6 @@
> * are handled as text/data or they can be discarded (which
> * often happens at runtime)
> */
> -#ifdef CONFIG_HOTPLUG
> -#define DEV_KEEP(sec) *(.dev##sec)
> -#define DEV_DISCARD(sec)
> -#else
> -#define DEV_KEEP(sec)
> -#define DEV_DISCARD(sec) *(.dev##sec)
> -#endif
> -
> #ifdef CONFIG_HOTPLUG_CPU
> #define CPU_KEEP(sec) *(.cpu##sec)
> #define CPU_DISCARD(sec)
> @@ -182,8 +174,6 @@
> *(.data) \
> *(.ref.data) \
> *(.data..shared_aligned) /* percpu related */ \
> - DEV_KEEP(init.data) \
> - DEV_KEEP(exit.data) \
..
> @@ -503,7 +489,6 @@
> /* init and exit section handling */
> #define INIT_DATA \
> *(.init.data) \
> - DEV_DISCARD(init.data) \

Shouldn't the effect of one of the above remain?

//Peter

[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]