public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] [3.10] mei: bus: Reset event_cb when disabling a device
Date: Tue, 21 May 2013 15:58:17 +0200	[thread overview]
Message-ID: <20130521135817.GE4589@zurbaran> (raw)

After cancelling all reads from the disable hook, we need to reset the
event_cb pointer as well or else we won't be able to set a new one up
when re-enabling the device.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---
 drivers/misc/mei/bus.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index 1e935ea..9ecd49a 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -496,6 +496,8 @@ int mei_cl_disable_device(struct mei_cl_device *device)
 		}
 	}
 
+	device->event_cb = NULL;
+
 	mutex_unlock(&dev->device_lock);
 
 	if (!device->ops || !device->ops->disable)
-- 
1.7.10.4

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

             reply	other threads:[~2013-05-21 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 13:58 Samuel Ortiz [this message]
2013-05-21 15:01 ` [PATCH] [3.10] mei: bus: Reset event_cb when disabling a device Winkler, Tomas
2013-05-21 16:51   ` Samuel Ortiz
2013-05-21 16:54   ` Greg KH (gregkh@linuxfoundation.org)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130521135817.GE4589@zurbaran \
    --to=sameo@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox