From: Oleg Nesterov <oleg@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>,
akpm@linux-foundation.org, jlayton@redhat.com,
lucas.demarchi@profusion.mobi, rusty@rustcorp.com.au,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
bharrosh@panasas.com, devel@openvz.org
Subject: Re: [RFC PATCH] kmod: add ability to swap root in usermode helper
Date: Tue, 21 May 2013 18:29:25 +0200 [thread overview]
Message-ID: <20130521162925.GA19785@redhat.com> (raw)
In-Reply-To: <20130521153531.GO14677@fieldses.org>
On 05/21, J. Bruce Fields wrote:
>
> On Tue, May 21, 2013 at 05:28:36PM +0200, Oleg Nesterov wrote:
> >
> > OK, so do not do this. Export the new helper.
>
> You mean, export umh_set_fs_root() in the above?
>
> That might be OK.
Yes, or even call_usermodehelper_root().
I didn't argue with the new helper that, yes, has the additional
argument. Although personally I think it would be better to not
add it into kmod.c (until it has more users), but I am not sure
there is a better place somewhere in nfs code. Whatever is more
convenient for you.
To me this looks like call_usermodehelper_keys().
Oleg.
next prev parent reply other threads:[~2013-05-21 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 7:00 [RFC PATCH] kmod: add ability to swap root in usermode helper Stanislav Kinsbursky
2013-05-20 8:42 ` Jeff Layton
2013-05-20 8:56 ` Stanislav Kinsbursky
2013-05-20 13:57 ` Oleg Nesterov
2013-05-20 14:43 ` Stanislav Kinsbursky
2013-05-20 15:10 ` Oleg Nesterov
2013-05-20 21:24 ` J. Bruce Fields
2013-05-21 15:28 ` Oleg Nesterov
2013-05-21 15:35 ` J. Bruce Fields
2013-05-21 16:29 ` Oleg Nesterov [this message]
2013-05-22 6:00 ` Stanislav Kinsbursky
2013-05-21 5:50 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521162925.GA19785@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=bharrosh@panasas.com \
--cc=devel@openvz.org \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=rusty@rustcorp.com.au \
--cc=skinsbursky@parallels.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox