From: Arnd Bergmann <arnd@arndb.de>
To: "Christian Daudt" <csd@broadcom.com>
Cc: "Grant Likely" <grant.likely@secretlab.ca>,
"Rob Herring" <rob.herring@calxeda.com>,
"Rob Landley" <rob@landley.net>,
"Russell King" <linux@arm.linux.org.uk>,
"Chris Ball" <cjb@laptop.org>,
"Stephen Warren" <swarren@nvidia.com>,
"Olof Johansson" <olof@lixom.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Wei WANG" <wei_wang@realsil.com.cn>,
"Ludovic Desroches" <ludovic.desroches@atmel.com>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
csd_b@daudt.org
Subject: Re: [PATCH V2 1/2] ARM: mmc: bcm281xx SDHCI driver
Date: Tue, 21 May 2013 20:23:03 +0200 [thread overview]
Message-ID: <201305212023.03272.arnd@arndb.de> (raw)
In-Reply-To: <519B2EAD.4000208@broadcom.com>
On Tuesday 21 May 2013, Christian Daudt wrote:
> >> + cfg = devm_kzalloc(&pdev->dev, sizeof(*cfg), GFP_KERNEL);
> >> + if (!cfg) {
> >> + dev_err(&pdev->dev, "Can't allocate platform cfg\n");
> >> + return NULL;
> >> + }
> > Not needed
> what is not needed ?
The allocation, it can be part of the sdhci_pltfm_host data.
> >> + const struct sdhci_pltfm_data *plat_data;
> > make it global.
> why make this global ?
Sorry for being unclear. I mean you can just use &sdhci_pltfm_data_kona
in the probe function, since the data is constant anyway, no need to have
a local variable for pulling this out of the device id.
Arnd
prev parent reply other threads:[~2013-05-21 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 15:48 [PATCH V2 1/2] ARM: mmc: bcm281xx SDHCI driver Christian Daudt
2013-05-10 15:48 ` [PATCH V2 2/2] ARM: mmc: bcm281xx SDHCI driver (dt mods) Christian Daudt
2013-05-22 18:01 ` Matt Porter
2013-05-16 22:09 ` [PATCH V2 1/2] ARM: mmc: bcm281xx SDHCI driver Arnd Bergmann
2013-05-21 8:22 ` Christian Daudt
2013-05-21 18:23 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305212023.03272.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=csd@broadcom.com \
--cc=csd_b@daudt.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ludovic.desroches@atmel.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@nvidia.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox