* [PATCH] rtc: rtc-twl: Fix missing device_init_wakeup() when booted with device tree
@ 2013-05-21 21:40 Tony Lindgren
0 siblings, 0 replies; only message in thread
From: Tony Lindgren @ 2013-05-21 21:40 UTC (permalink / raw)
To: Alessandro Zummo; +Cc: rtc-linux, linux-omap, linux-kernel, Kevin Hilman
When booted in legacy mode device_init_wakeup() gets called
by drivers/mfd/twl-core.c when the children are initialized.
However, when booted using device tree, the children are
created with of_platform_populate() instead add_children().
This means that the RTC driver will not have device_init_wakeup()
set, and we need to call it from the driver probe like RTC drivers
typically do.
Without this we cannot test PM wake-up events on omaps for
cases where there may not be any physical wake-up event.
Reported-by: Kevin Hilman <khilman@linaro.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
This fix is for the -rc cycle please.
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -524,6 +524,7 @@ static int twl_rtc_probe(struct platform_device *pdev)
}
platform_set_drvdata(pdev, rtc);
+ device_init_wakeup(&pdev->dev, 1);
return 0;
out2:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-05-21 21:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-21 21:40 [PATCH] rtc: rtc-twl: Fix missing device_init_wakeup() when booted with device tree Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox