From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com,
nicolas.ferre@atmel.com, linux@maxim.org.za
Subject: Re: [PATCH] ARM: at91: Fix: Change internal SRAM memory type to "MT_MEMORY_SO"
Date: Wed, 22 May 2013 01:14:57 +0100 [thread overview]
Message-ID: <20130522001457.GA18614@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1369011979-21354-1-git-send-email-wenyou.yang@atmel.com>
On Mon, May 20, 2013 at 09:06:19AM +0800, Wenyou Yang wrote:
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
This needs more of a description. Also, for a single patch, it's silly
to send two mails, the first being a cover which has a little more
information in it about the patch than the patch itself.
You need to explain _why_ you're making this change. What I want to see
is that you've thought about the implications of this - particularly that
you know that strongly ordered memory does *not* imply any ordering with
any other memory types.
In other words, I want to know that this change is not a bodge but there's
a real reason behind it.
next prev parent reply other threads:[~2013-05-22 0:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 1:05 [PATCH] Change internal SRAM memory type to "MT_MEMORY_SO" Wenyou Yang
2013-05-20 1:06 ` [PATCH] ARM: at91: Fix: " Wenyou Yang
2013-05-21 9:06 ` Nicolas Ferre
2013-05-22 0:14 ` Russell King - ARM Linux [this message]
2013-05-24 7:11 ` Yang, Wenyou
2013-05-24 11:20 ` Russell King - ARM Linux
2013-05-24 14:03 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-24 16:40 ` Russell King - ARM Linux
2013-05-24 16:52 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-24 16:59 ` Russell King - ARM Linux
2013-05-24 17:11 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-21 9:06 ` [PATCH] " Nicolas Ferre
2013-06-08 2:17 ` [PATCH] Change the internal SRAM memory type MT_MEMORY_NONCACHED Wenyou Yang
2013-06-13 13:19 ` Nicolas Ferre
2013-06-13 13:43 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522001457.GA18614@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox