From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755462Ab3EVHzz (ORCPT ); Wed, 22 May 2013 03:55:55 -0400 Received: from mga02.intel.com ([134.134.136.20]:55885 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752648Ab3EVHzy (ORCPT ); Wed, 22 May 2013 03:55:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,718,1363158000"; d="scan'208";a="317607844" Date: Wed, 22 May 2013 10:58:54 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: Linus Walleij , David Cohen , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] gpio-langwell: do not use direct access to iomapped memory Message-ID: <20130522075854.GV11878@intel.com> References: <1369208859-16514-1-git-send-email-andriy.shevchenko@linux.intel.com> <1369208859-16514-3-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369208859-16514-3-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2013 at 10:47:37AM +0300, Andy Shevchenko wrote: > We better to use readl() function instead of bad looking direct access. > > Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg