From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
David Cohen <david.a.cohen@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] gpio-langwell: amend error messages
Date: Wed, 22 May 2013 11:06:23 +0300 [thread overview]
Message-ID: <20130522080623.GX11878@intel.com> (raw)
In-Reply-To: <1369208859-16514-5-git-send-email-andriy.shevchenko@linux.intel.com>
On Wed, May 22, 2013 at 10:47:39AM +0300, Andy Shevchenko wrote:
> There is no need to use hardcoded device name in the error messages, because
> dev_err() prefixes the message with the device name anyway.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2013-05-22 8:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 7:47 [PATCH v2 0/4] gpio-langwell: bugfix and amendments Andy Shevchenko
2013-05-22 7:47 ` [PATCH v2 1/4] gpio-langwell: initialize lock before usage Andy Shevchenko
2013-05-22 7:58 ` Mika Westerberg
2013-05-22 7:47 ` [PATCH v2 2/4] gpio-langwell: do not use direct access to iomapped memory Andy Shevchenko
2013-05-22 7:58 ` Mika Westerberg
2013-05-22 7:47 ` [PATCH v2 3/4] gpio-langwell: use managed functions pcim_* and devm_* Andy Shevchenko
2013-05-22 8:05 ` Mika Westerberg
2013-05-22 8:36 ` Andy Shevchenko
2013-05-22 8:50 ` Mika Westerberg
2013-05-22 7:47 ` [PATCH v2 4/4] gpio-langwell: amend error messages Andy Shevchenko
2013-05-22 8:06 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522080623.GX11878@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david.a.cohen@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox