From: David Brown <davidb@codeaurora.org>
To: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] msm: iommu: fix leak and invalid access
Date: Wed, 22 May 2013 15:30:10 -0700 [thread overview]
Message-ID: <20130522223009.GA11823@codeaurora.org> (raw)
In-Reply-To: <51931347.7020600@huawei.com>
On Wed, May 15, 2013 at 12:47:03PM +0800, Libo Chen wrote:
> This patch merge two patch that I sended before:
> 1. msm: iommu: add missing platform_device_unregister() in err case
> 2. msm: iommu: no need kfree before kzalloc successful
>
> It fixes two obvious problems:
> 1. We have registered msm_iommu_driver first, and need unregister it when
> registered msm_iommu_ctx_driver fail
>
> 2. We don`t need to kfree drvdata before kzalloc successful
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> drivers/iommu/msm_iommu_dev.c | 11 +++++------
> 1 files changed, 5 insertions(+), 6 deletions(-)
Acked-by: David Brown <davidb@codeaurora.org>
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-05-22 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 4:47 [PATCH] msm: iommu: fix leak and invalid access Libo Chen
2013-05-22 5:58 ` Libo Chen
2013-05-22 22:29 ` David Brown
2013-05-23 1:23 ` Libo Chen
2013-05-28 12:27 ` Joerg Roedel
2013-05-28 12:37 ` Libo Chen
2013-05-22 22:30 ` David Brown [this message]
2013-05-23 23:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522223009.GA11823@codeaurora.org \
--to=davidb@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=clbchenlibo.chen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox