public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Axel Lin <axel.lin@ingics.com>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
Date: Thu, 23 May 2013 10:39:34 +0900	[thread overview]
Message-ID: <20130523013933.GI22608@verge.net.au> (raw)
In-Reply-To: <1454213.B1kNpQ6JtX@avalon>

On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote:
> Hi Axel,
> 
> Thank you for the patch.
> 
> On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks. I have queued this up for v3.11 in the pinmux branch
of my renesas tree on kernel.org.

> 
> > ---
> >  drivers/pwm/pwm-renesas-tpu.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
> > index 8e6d8d7..319a6fe 100644
> > --- a/drivers/pwm/pwm-renesas-tpu.c
> > +++ b/drivers/pwm/pwm-renesas-tpu.c
> > @@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev)
> >  {
> >  	struct tpu_device *tpu = platform_get_drvdata(pdev);
> >  	unsigned int i;
> > +	int ret;
> > +
> > +	ret = pwmchip_remove(&tpu->chip);
> > +	if (ret)
> > +		return ret;
> > 
> >  	for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) {
> >  		struct tpu_pwm_device *pwm = &tpu->pwms[i];
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2013-05-23  1:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 13:45 [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove() Axel Lin
2013-05-20 13:46 ` Laurent Pinchart
2013-05-23  1:39   ` Simon Horman [this message]
2013-05-23 19:12     ` Thierry Reding
2013-05-25  5:33       ` Simon Horman
2013-05-25 13:42       ` Laurent Pinchart
2013-05-25 15:20         ` Axel Lin
2013-05-26  9:18         ` Thierry Reding
2013-05-29 14:39           ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130523013933.GI22608@verge.net.au \
    --to=horms@verge.net.au \
    --cc=axel.lin@ingics.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox