From: Dave Jones <davej@redhat.com>
To: Ben Minerds <puzzleduck@gmail.com>
Cc: greg@kroah.com, rob@landley.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] Documentation: Adding "The Perfect Patch" by Andrew Morton
Date: Thu, 23 May 2013 13:15:30 -0400 [thread overview]
Message-ID: <20130523171530.GK16419@redhat.com> (raw)
In-Reply-To: <5114385ce1897015ad96f59f0fd46014d5f07786.1369312746.git.PuZZleDucK@gmail.com>
On Thu, May 23, 2013 at 10:49:53PM +1000, Ben Minerds wrote:
> +- Don't bother mentioning what version of the kernel the patch applies to
> + ("applies to 2.6.8-rc1"). This is not interesting information - once the
> + patch is in bitkeeper, of _course_ it applied, and it'll probably be merged
> + into a later kernel than the one which you wrote it for.
> +
> +- Do not refer to earlier patches when changelogging a new version of a
> + patch. It's not very useful to have a bitkeeper changelog which says "OK,
> + this fixes the things you mentioned yesterday". Each iteration of the patch
> + should contain a standalone changelog. This implies that you need a patch
> + management system which maintains changelogs. See below.
s/bitkeeper/git/
> +- Make sure that your patches apply to the latest version of the kernel
> + tree. Either straight from bitkeeper or from
> + ftp://ftp.kernel.org/pub/linux/kernel/v2.6/snapshots/
ditto. (Also, update url)
Dave
next prev parent reply other threads:[~2013-05-23 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 12:49 [PATCH 0/8] Documentation: Updating docs and links relating to patches Ben Minerds
2013-05-23 12:49 ` [PATCH 1/8] Documentation: Adding "The Perfect Patch" by Andrew Morton Ben Minerds
2013-05-23 17:15 ` Dave Jones [this message]
2013-05-24 4:10 ` Rob Landley
2013-05-24 4:16 ` Joe Perches
2013-05-23 12:49 ` [PATCH 2/8] Documentation: Adding "Linux Kernel Patch Submission Format" Ben Minerds
2013-05-24 4:12 ` Rob Landley
2013-05-23 12:49 ` [PATCH 3/8] Documentation: Replacing references to broken perfect patch URL Ben Minerds
2013-05-23 12:49 ` [PATCH 4/8] Documentation: Replacing reference " Ben Minerds
2013-05-23 12:49 ` [PATCH 5/8] Documentation: Replacing reference to broken submission format URL Ben Minerds
2013-05-24 4:16 ` Rob Landley
2013-05-23 12:49 ` [PATCH 6/8] Documentation: Updating a broken link in "the perfect patch" Ben Minerds
2013-05-24 4:21 ` Rob Landley
2013-05-23 12:49 ` [PATCH 7/8] Documentation: Reformatting "Linux Kernel Patch Submission Format" Ben Minerds
2013-05-23 12:50 ` [PATCH 8/8] Documentation: Move other patch related document Ben Minerds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523171530.GK16419@redhat.com \
--to=davej@redhat.com \
--cc=greg@kroah.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puzzleduck@gmail.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox