From: Anton Vorontsov <anton@enomsg.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: jason.wessel@windriver.com, sasha.levin@oracle.com,
vincent.stehle@laposte.net, john.blackwood@ccur.com,
kgdb-bugreport@lists.sourceforge.net,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas.
Date: Thu, 23 May 2013 10:28:49 -0700 [thread overview]
Message-ID: <20130523172849.GB30160@teo> (raw)
In-Reply-To: <5194C23A.3090405@asianux.com>
On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote:
> Delete waste '{' for 'case' statement.
>
> For the return variable 'long res' in function kdb_task_state_string(),
> neither it matches the function return type 'unsigned long', nor is
> suitable as a flag variable to make 'or' operation. So use 'unsigned
> long' instead of 'long'.
>
> If "case 'A'" happen in function kdb_task_state_string(), can return
> ~0UL directly to save the useless looping.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
If anything, these should be 3 separate patches...
Thanks!
Anton
next prev parent reply other threads:[~2013-05-23 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 11:25 [PATCH] kernel/debug/kdb: code enhancement for 3 areas Chen Gang
2013-05-23 17:28 ` Anton Vorontsov [this message]
2013-05-24 1:18 ` Chen Gang
2013-05-28 6:07 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523172849.GB30160@teo \
--to=anton@enomsg.org \
--cc=gang.chen@asianux.com \
--cc=jason.wessel@windriver.com \
--cc=john.blackwood@ccur.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox