From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Wolfram Sang <wsa@the-dreams.de>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
linux-doc@vger.kernel.org, Emilio Lopez <emilio@elopez.com.ar>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
linux-i2c@vger.kernel.org, Rob Landley <rob@landley.net>,
sunny@allwinnertech.com, shuge@allwinnertech.com,
kevin@allwinnertech.com
Subject: Re: [PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver
Date: Sat, 25 May 2013 17:22:31 +0200 [thread overview]
Message-ID: <20130525152231.GF17847@lukather> (raw)
In-Reply-To: <2868419.vHvm2rOVdd@flatron>
Hi Tomasz,
On Sat, May 25, 2013 at 02:06:51PM +0200, Tomasz Figa wrote:
> Hi Maxime,
>
> Overall the driver looks good, just some minor nitpicks inline.
Thanks for the review!
I'll fix the comments you had and send a new version.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-05-25 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1367572669-24354-1-git-send-email-maxime.ripard@free-electrons.com>
2013-05-03 9:17 ` [PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver Maxime Ripard
2013-05-25 12:06 ` Tomasz Figa
2013-05-25 15:22 ` Maxime Ripard [this message]
2013-05-03 9:17 ` [PATCH 2/5] ARM: sunxi: dt: Add i2c controller nodes to the DTSI Maxime Ripard
2013-05-03 9:17 ` [PATCH 3/5] ARM: sun4i: dt: Add i2c muxing options Maxime Ripard
2013-05-03 9:17 ` [PATCH 4/5] ARM: sun5i: " Maxime Ripard
2013-05-03 9:17 ` [PATCH 5/5] ARM: sun5i: olinuxino: Enable the i2c controllers Maxime Ripard
[not found] <1367491557-6027-1-git-send-email-maxime.ripard@free-electrons.com>
2013-05-02 10:45 ` [PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130525152231.GF17847@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=emilio@elopez.com.ar \
--cc=grant.likely@secretlab.ca \
--cc=kevin@allwinnertech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
--cc=tomasz.figa@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox