* [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate
@ 2013-05-24 19:37 Fabio Estevam
2013-05-27 7:07 ` Shawn Guo
2013-05-27 10:06 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2013-05-24 19:37 UTC (permalink / raw)
To: vinod.koul; +Cc: shawn.guo, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Fix the following sparse warning:
drivers/dma/mxs-dma.c:696:17: warning: symbol 'mxs_dma_xlate' was not declared. Should it be static?
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/dma/mxs-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index b48a79c..7195930 100644
--- a/drivers/dma/mxs-dma.c
+++ b/drivers/dma/mxs-dma.c
@@ -693,7 +693,7 @@ static bool mxs_dma_filter_fn(struct dma_chan *chan, void *fn_param)
return true;
}
-struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
+static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
struct of_dma *ofdma)
{
struct mxs_dma_engine *mxs_dma = ofdma->of_dma_data;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate
2013-05-24 19:37 [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate Fabio Estevam
@ 2013-05-27 7:07 ` Shawn Guo
2013-05-27 10:06 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2013-05-27 7:07 UTC (permalink / raw)
To: Fabio Estevam; +Cc: vinod.koul, linux-kernel, Fabio Estevam
On Fri, May 24, 2013 at 04:37:27PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fix the following sparse warning:
>
> drivers/dma/mxs-dma.c:696:17: warning: symbol 'mxs_dma_xlate' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/dma/mxs-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index b48a79c..7195930 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -693,7 +693,7 @@ static bool mxs_dma_filter_fn(struct dma_chan *chan, void *fn_param)
> return true;
> }
>
> -struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> +static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> struct of_dma *ofdma)
> {
> struct mxs_dma_engine *mxs_dma = ofdma->of_dma_data;
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate
2013-05-24 19:37 [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate Fabio Estevam
2013-05-27 7:07 ` Shawn Guo
@ 2013-05-27 10:06 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2013-05-27 10:06 UTC (permalink / raw)
To: Fabio Estevam; +Cc: shawn.guo, linux-kernel, Fabio Estevam
On Fri, May 24, 2013 at 04:37:27PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fix the following sparse warning:
>
> drivers/dma/mxs-dma.c:696:17: warning: symbol 'mxs_dma_xlate' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, Thanks
--
~Vinod
> ---
> drivers/dma/mxs-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
> index b48a79c..7195930 100644
> --- a/drivers/dma/mxs-dma.c
> +++ b/drivers/dma/mxs-dma.c
> @@ -693,7 +693,7 @@ static bool mxs_dma_filter_fn(struct dma_chan *chan, void *fn_param)
> return true;
> }
>
> -struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> +static struct dma_chan *mxs_dma_xlate(struct of_phandle_args *dma_spec,
> struct of_dma *ofdma)
> {
> struct mxs_dma_engine *mxs_dma = ofdma->of_dma_data;
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-27 10:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-24 19:37 [PATCH] dma: mxs-dma: Staticize mxs_dma_xlate Fabio Estevam
2013-05-27 7:07 ` Shawn Guo
2013-05-27 10:06 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox