From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Stephane Eranian <eranian@google.com>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also
Date: Tue, 28 May 2013 10:48:33 +0200 [thread overview]
Message-ID: <20130528084833.GA30172@gmail.com> (raw)
In-Reply-To: <20130522095215.GA2386@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> >
> > Add a new column for showing callchain overhead. I feel like it's
> > more natural than having those overhead next to a first child in a
> > same column.
>
> Callchains in GTK, great! Some observations tho:
>
> All those leaves with 0.00% looks ugly/not needed, right?
>
> I took a screenshot and put at:
>
> http://vger.kernel.org/~acme/perf-gtk-callchains.png
Looks really nice!
I'm wondering, would it be hard to add alternating lightgrey+white
background colors to make the entries striped and for the horizontal
structure to thus stand out better?
The 'qgit' tool does that for example, to alternate git commit log
entries.
(Extra points for striping only where the line actually begins.)
Thanks,
Ingo
next prev parent reply other threads:[~2013-05-28 8:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 8:27 [PATCH 0/5] perf report: Add support for callchains on GTK browser Namhyung Kim
2013-05-22 8:27 ` [PATCH 1/5] perf gtk/hists: Use GtkTreeStore instead of GtkListStore Namhyung Kim
2013-05-22 8:37 ` Pekka Enberg
2013-05-22 8:27 ` [PATCH 2/5] perf gtk/hists: Add support for callchains Namhyung Kim
2013-05-22 8:38 ` Pekka Enberg
2013-05-22 8:27 ` [PATCH 3/5] perf gtk/hists: Display callchain overhead also Namhyung Kim
2013-05-22 8:39 ` Pekka Enberg
2013-05-22 9:52 ` Arnaldo Carvalho de Melo
2013-05-23 2:37 ` Namhyung Kim
2013-05-28 8:48 ` Ingo Molnar [this message]
2013-06-02 2:50 ` Namhyung Kim
2013-05-22 8:27 ` [PATCH 4/5] perf gtk/hists: Add a double-click handler for callchains Namhyung Kim
2013-05-22 8:39 ` Pekka Enberg
2013-05-22 8:27 ` [PATCH 5/5] perf gtk/hists: Make column headers resizable Namhyung Kim
2013-05-22 8:37 ` [PATCH v2 " Namhyung Kim
2013-05-22 8:39 ` Pekka Enberg
2013-05-22 8:40 ` [PATCH 0/5] perf report: Add support for callchains on GTK browser Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528084833.GA30172@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).