From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: John Stultz <john.stultz@linaro.org>,
Jan Beulich <JBeulich@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/3] timekeeping: sync persistent clock and RTC on system time step changes
Date: Tue, 28 May 2013 14:31:37 -0400 [thread overview]
Message-ID: <20130528183137.GA23213@phenom.dumpdata.com> (raw)
In-Reply-To: <51A4F6C6.8080808@citrix.com>
On Tue, May 28, 2013 at 07:26:14PM +0100, David Vrabel wrote:
> On 15/05/13 19:10, John Stultz wrote:
> >
> > Ok, so really, as soon as the Dom0 time is set by NTP, all guests will
> > see the right time? That makes more sense, and means the window for
> > these sorts of issues is reasonably quite small.
>
> It's a small window but it's occurring in our automated test system.
>
> > David: So I'm less inclined to merge this individual change, but if you
> > still feel strongly about it, let me know and we can circle around on it
> > after you've addressed the specific issues I pointed out earlier.
>
> This patch was the actual bug fix but I've reworked it to use the
> pvclock_gtod notifier chain as this seemed to be what KVM hosts were
> using to maintain a clock for guests. Please review the new series, thanks.
Looks good.
John if you are OK I am thinking to push this to Linus shortly as it is
fixing a bug.
>
> David
next prev parent reply other threads:[~2013-05-28 18:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 17:56 [PATCH 0/3] x86,time,xen: maintain an accurate persistent clock in more cases David Vrabel
2013-05-13 17:56 ` [PATCH 1/3] x86: increase precision of x86_platform.get/set_wallclock() David Vrabel
2013-05-14 0:57 ` John Stultz
2013-05-14 17:52 ` John Stultz
2013-05-29 0:18 ` John Stultz
2013-05-29 12:16 ` David Vrabel
2013-05-13 17:56 ` [PATCH 2/3] timekeeping: sync persistent clock and RTC on system time step changes David Vrabel
2013-05-14 0:40 ` John Stultz
2013-05-14 9:47 ` David Vrabel
2013-05-14 17:15 ` John Stultz
2013-05-15 8:16 ` [Xen-devel] " Jan Beulich
2013-05-15 18:10 ` John Stultz
2013-05-28 18:26 ` David Vrabel
2013-05-28 18:31 ` Konrad Rzeszutek Wilk [this message]
2013-05-28 19:09 ` John Stultz
2013-05-28 19:48 ` Konrad Rzeszutek Wilk
2013-05-28 20:03 ` John Stultz
2013-05-28 20:11 ` John Stultz
2013-05-28 20:25 ` Konrad Rzeszutek Wilk
2013-05-28 20:30 ` John Stultz
2013-05-28 19:06 ` John Stultz
2013-05-13 17:56 ` [PATCH 3/3] x86/xen: sync the CMOS RTC as well as the Xen wallclock David Vrabel
2013-05-14 0:52 ` John Stultz
2013-05-14 7:57 ` [Xen-devel] " Jan Beulich
2013-05-14 15:59 ` John Stultz
2013-05-14 16:14 ` Jan Beulich
2013-05-14 16:17 ` John Stultz
2013-05-14 16:24 ` Konrad Rzeszutek Wilk
2013-05-14 16:28 ` John Stultz
2013-05-14 9:55 ` David Vrabel
2013-05-14 17:24 ` John Stultz
2013-05-14 18:00 ` David Vrabel
2013-05-14 18:03 ` John Stultz
2013-05-15 8:19 ` [Xen-devel] " Jan Beulich
2013-05-15 18:13 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528183137.GA23213@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).