From: Lee Jones <lee.jones@linaro.org>
To: Leon Romanovsky <leon@leon.nu>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc
Date: Tue, 28 May 2013 20:16:08 +0100 [thread overview]
Message-ID: <20130528191608.GB3012@gmail.com> (raw)
In-Reply-To: <CALq1K=LGuA4Jqa0qmenLNJZCbLf4XhZoA-wd-pkcR+bMbenBGw@mail.gmail.com>
On Tue, 28 May 2013, Leon Romanovsky wrote:
> On Tue, May 28, 2013 at 7:24 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Tue, May 28, 2013 at 12:02 PM, Lee Jones <lee.jones@linaro.org> wrote:
> >> On Mon, 27 May 2013, Leon Romanovsky wrote:
> >
> >>> > > + init_data = devm_kzalloc(&tps65912->dev,
> >
> > There is an obvious typo: no need of & here if I got it correctly.
> >
> >> drivers/mfd/tps65912-core.c: In function ‘tps65912_device_init’:
> >> drivers/mfd/tps65912-core.c:131:18: warning: passing argument 1 of ‘devm_kzalloc’ from incompatible pointer type [enabled by default]
> >> In file included from include/linux/platform_device.h:14:0,
> >> from include/linux/mfd/core.h:17,
> >> from drivers/mfd/tps65912-core.c:21:
> >> include/linux/device.h:574:14: note: expected ‘struct device *’ but argument is of type ‘struct device **’
> You are absolutely right, I sent the wrong patch with typo :(
>
> Lee,
> Do I need to resend it ? Or you can fix it by yourself ?
I've already fixed it up and tested.
I just wanted to clarify exactly what happened, as it couldn't have
been tested.
No worries, patch applied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-05-28 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 9:19 [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc Leon Romanovsky
2013-05-17 18:07 ` Leon Romanovsky
2013-05-23 8:23 ` Lee Jones
2013-05-23 7:35 ` Lee Jones
2013-05-23 8:37 ` Lee Jones
[not found] ` <CALq1K=Las2mwV9x6ajEUDYg6nLbcK2KVLK8TH2B1f=9fQ7JfTg@mail.gmail.com>
2013-05-28 9:02 ` Lee Jones
2013-05-28 16:24 ` Andy Shevchenko
2013-05-28 18:36 ` Leon Romanovsky
2013-05-28 19:16 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528191608.GB3012@gmail.com \
--to=lee.jones@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=leon@leon.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).