From: Ingo Molnar <mingo@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org,
david.a.cohen@intel.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:irq/core] irq/x86/io_apic: Fix number of pre-allocated irqs
Date: Wed, 29 May 2013 11:19:50 +0200 [thread overview]
Message-ID: <20130529091950.GB25621@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1305291104550.2995@ionos>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Tue, 28 May 2013, tip-bot for David Cohen wrote:
>
> > Commit-ID: 8c956b1b935ec98decb470a6abff8c1f8b28e9f0
> > Gitweb: http://git.kernel.org/tip/8c956b1b935ec98decb470a6abff8c1f8b28e9f0
> > Author: David Cohen <david.a.cohen@intel.com>
> > AuthorDate: Tue, 30 Apr 2013 16:20:15 -0700
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Tue, 28 May 2013 12:01:29 +0200
> >
> > irq/x86/io_apic: Fix number of pre-allocated irqs
> >
> > arch_probe_nr_irqs() has a typo when returning number of
> > preallocated irqs. Instead of returning the calculated value, it
> > returns a constant number NR_IRQ_LEGACY.
>
> That's not a typo. That's on purpose.
>
> We don't want to allocate a gazillion of interrupt descriptors for
> nothing. The only ones which must be pre-allocated are the legacy
> ones.
>
> > This patch makes sure the calculated value is returned intead.
>
> And therefor defeats the whole purpose of sparse irqs.
>
> I'll zap that commit.
Oops, I had a sneaking suspicion about this change but did not read the
code far enough - thanks for correcting my brainfart!
Thanks,
Ingo
prev parent reply other threads:[~2013-05-29 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 23:20 [PATCH] x86, io_apic: Fix number of pre-allocated irqs David Cohen
2013-05-28 13:38 ` [tip:irq/core] irq/x86/io_apic: " tip-bot for David Cohen
2013-05-29 9:08 ` Thomas Gleixner
2013-05-29 9:19 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529091950.GB25621@gmail.com \
--to=mingo@kernel.org \
--cc=david.a.cohen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox