From: Oleg Nesterov <oleg@redhat.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: James Hogan <james.hogan@imgtec.com>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
Ralf Baechle <ralf@linux-mips.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS)
Date: Wed, 29 May 2013 19:36:34 +0200 [thread overview]
Message-ID: <20130529173634.GA2020@redhat.com> (raw)
In-Reply-To: <51A638A4.2000705@gmail.com>
On 05/29, David Daney wrote:
>
> On 05/29/2013 10:01 AM, James Hogan wrote:
>> MIPS has 128 signals, the highest of which has the number 128. The
>
> I wonder if we should change the ABI and reduce the number of signals to
> 127 instead of this patch.
Same thoughts...
>> @@ -2366,8 +2366,12 @@ relock:
>>
>> /*
>> * Death signals, no core dump.
>> + *
>> + * MIPS has a signal number 128 which clashes with the core dump
>> + * bit. If this was the signal we still want to report a valid
>> + * exit code, so round it down to 127.
>> */
>> - do_group_exit(info->si_signo);
>> + do_group_exit(min(info->si_signo, 127));
This avoids BUG_ON() but obviously fools WIFSIGNALED(), doesn't look
very nice.
Oleg.
next prev parent reply other threads:[~2013-05-29 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 17:01 [RFC PATCH] kernel/signal.c: avoid BUG_ON with SIG128 (MIPS) James Hogan
2013-05-29 17:19 ` David Daney
2013-05-29 17:36 ` Oleg Nesterov [this message]
2013-05-29 21:56 ` James Hogan
2013-06-28 20:03 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529173634.GA2020@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ddaney.cavm@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox