From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave@sr71.net>
Cc: mingo@redhat.com, paulus@samba.org, acme@ghostprotocols.net,
tglx@linutronix.de, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v3][PATCH 2/4] x86: warn when NMI handlers take large amounts of time
Date: Thu, 30 May 2013 11:37:17 +0200 [thread overview]
Message-ID: <20130530093717.GM12193@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20130529222759.6D8C68B2@viggo.jf.intel.com>
On Wed, May 29, 2013 at 03:27:59PM -0700, Dave Hansen wrote:
> +static u64 nmi_longest_ns = 1000 * 1000 * 1000;
1s? Isn't that a tad too long?
FWIW there's NSEC_PER_{U,M,}SEC for such cases, I find those macros
increase readability.
next prev parent reply other threads:[~2013-05-30 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 22:27 [v3][PATCH 0/4] Work around perf NMI-induced hangs Dave Hansen
2013-05-29 22:27 ` [v3][PATCH 1/4] perf/x86: only print PMU state when also WARN()'ing Dave Hansen
2013-05-29 22:27 ` [v3][PATCH 2/4] x86: warn when NMI handlers take large amounts of time Dave Hansen
2013-05-30 8:33 ` Ingo Molnar
2013-05-30 9:37 ` Peter Zijlstra [this message]
2013-05-29 22:28 ` [v3][PATCH 3/4] perf: drop sample rate when sampling is too slow Dave Hansen
2013-05-29 22:28 ` [v3][PATCH 4/4] x86: nmi length tracepoints Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530093717.GM12193@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@ghostprotocols.net \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox