From: Vinod Koul <vinod.koul@intel.com>
To: Denis Efremov <yefremov.denis@gmail.com>
Cc: Viresh Kumar <viresh.linux@gmail.com>, Dan Williams <djbw@fb.com>,
linux-kernel@vger.kernel.org, trivial@kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH 09/21] dw_dmac: remove inline marking of EXPORT_SYMBOL functions
Date: Thu, 30 May 2013 23:31:26 +0530 [thread overview]
Message-ID: <20130530180126.GG3767@intel.com> (raw)
In-Reply-To: <1368091192-10245-4-git-send-email-yefremov.denis@gmail.com>
On Thu, May 09, 2013 at 01:19:40PM +0400, Denis Efremov wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Applied, thanks
--
~Vinod
> ---
> drivers/dma/dw_dmac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index 43a5329..a526bb9 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -574,14 +574,14 @@ static void dwc_handle_error(struct dw_dma *dw, struct dw_dma_chan *dwc)
>
> /* --------------------- Cyclic DMA API extensions -------------------- */
>
> -inline dma_addr_t dw_dma_get_src_addr(struct dma_chan *chan)
> +dma_addr_t dw_dma_get_src_addr(struct dma_chan *chan)
> {
> struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
> return channel_readl(dwc, SAR);
> }
> EXPORT_SYMBOL(dw_dma_get_src_addr);
>
> -inline dma_addr_t dw_dma_get_dst_addr(struct dma_chan *chan)
> +dma_addr_t dw_dma_get_dst_addr(struct dma_chan *chan)
> {
> struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
> return channel_readl(dwc, DAR);
> --
> 1.8.1.4
>
--
next prev parent reply other threads:[~2013-05-30 18:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 7:57 [PATCH 00/21] Exported funtions that are marked inline Denis Efremov
2013-05-09 7:58 ` [PATCH 01/21] [SCSI] libiscsi: remove inline marking of EXPORT_SYMBOL functions Denis Efremov
2013-05-09 7:58 ` [PATCH 02/21] fs: " Denis Efremov
2013-05-09 8:07 ` Al Viro
2013-05-09 8:42 ` Denis
2013-05-09 7:58 ` [PATCH 03/21] x86: " Denis Efremov
2013-05-09 13:50 ` H. Peter Anvin
2013-05-09 7:58 ` [PATCH 04/21] NFC: " Denis Efremov
2013-05-09 7:58 ` [PATCH 05/21] 9p: " Denis Efremov
2013-05-09 9:19 ` [PATCH 06/21] staging: nvec: " Denis Efremov
2013-05-09 9:19 ` [PATCH 07/21] netfilter: nf_nat: " Denis Efremov
2013-05-09 9:47 ` David Laight
2013-05-09 9:19 ` [PATCH 08/21] iwlegacy: " Denis Efremov
2013-05-09 9:19 ` [PATCH 09/21] dw_dmac: " Denis Efremov
[not found] ` <CAHp75VfWzzevr6AQzE25P8FUXd=amzL5-XgkJXvbRDESF=M76A@mail.gmail.com>
2013-05-12 15:13 ` Viresh Kumar
2013-05-30 18:01 ` Vinod Koul [this message]
2013-05-09 9:19 ` [PATCH 10/21] mm: filemap: " Denis Efremov
2013-05-09 9:19 ` [PATCH 11/21] ipv4: ip_output: " Denis Efremov
2013-05-11 23:13 ` David Miller
2013-05-09 10:36 ` [PATCH 12/21] metag: delay: " Denis Efremov
2013-05-09 11:03 ` James Hogan
2013-05-09 10:36 ` [PATCH 13/21] openrisc: " Denis Efremov
2013-05-09 10:45 ` Will Deacon
2013-05-09 10:36 ` [PATCH 14/21] arm64: " Denis Efremov
2013-05-09 10:39 ` Catalin Marinas
2013-05-09 10:36 ` [PATCH 15/21] arch/tile: " Denis Efremov
2013-05-09 18:02 ` Chris Metcalf
2013-05-09 10:36 ` [PATCH 16/21] sparc: " Denis Efremov
2013-05-09 10:36 ` [PATCH 17/21] CRISv32: " Denis Efremov
2013-05-14 16:35 ` Jesper Nilsson
2013-05-09 10:36 ` [PATCH 18/21] m68k/sun3/: " Denis Efremov
2013-05-09 11:09 ` Geert Uytterhoeven
2013-05-09 10:36 ` [PATCH 19/21] MIPS: MSP71xx: " Denis Efremov
2013-05-09 10:36 ` [PATCH 20/21] powerpc/ps3: " Denis Efremov
2013-05-09 11:35 ` Geoff Levand
2013-05-17 16:05 ` Geert Uytterhoeven
2013-05-28 23:14 ` Geoff Levand
2013-05-09 10:36 ` [PATCH 21/21] ARM: " Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530180126.GG3767@intel.com \
--to=vinod.koul@intel.com \
--cc=djbw@fb.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=viresh.linux@gmail.com \
--cc=yefremov.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox