From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Hanjun Guo <hanjun.guo@linaro.org>,
Martin Mokrejs <mmokrejs@fold.natur.cuni.cz>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@linaro.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] ACPI: Fix potential NULL pointer dereference in acpi_processor_add()
Date: Fri, 31 May 2013 07:25:42 +0900 [thread overview]
Message-ID: <20130530222542.GD1630@kroah.com> (raw)
In-Reply-To: <2969934.XTKV7y9VVT@vostro.rjw.lan>
On Thu, May 30, 2013 at 03:57:58PM +0200, Rafael J. Wysocki wrote:
> On Thursday, May 30, 2013 10:29:54 AM Hanjun Guo wrote:
> > On 2013-5-29 19:07, Martin Mokrejs wrote:
> > > Hanjun Guo wrote:
> > >> On 2013-5-29 7:30, Rafael J. Wysocki wrote:
> > >>> On Thursday, May 23, 2013 08:44:26 PM Hanjun Guo wrote:
> > >>>> In acpi_processor_add(), get_cpu_device() will return NULL sometimes,
> > >>>> although the chances are small, I think it should be fixed.
> > >>>>
> > >>>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> > >>>
> > >>> This patch isn't necessary any more after the changes queued up for 3.11
> > >>> in the acpi-hotplug branch of the linux-pm.git tree.
> > >>
> > >> Ok, I noticed your patch set, just drop my patch.
> > >
> > > But shouldn't this go to stable at least? I checked linux-3.9.4
> > > and it applies fine. Whether this is relevant for other stable
> > > series I will leave up to somebody else. ;)
> >
> > Hi Rafeal,
> >
> > What's your opinion on Martin's suggestion?
>
> Well, this is kind of hard to say. We generally don't apply patches to -stable
> that don't have mainline counterparts.
>
> Greg, I wonder what your opinion is?
We do not apply patches to -stable that are not in Linus's tree, unless
there is no problem in Linus's tree due to a major rewrite of the code,
and it has been confirmed that the same problem isn't there.
thanks,
greg k-h
next prev parent reply other threads:[~2013-05-30 22:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 12:44 [PATCH] ACPI: Fix potential NULL pointer dereference in acpi_processor_add() Hanjun Guo
2013-05-28 23:30 ` Rafael J. Wysocki
2013-05-29 1:38 ` Hanjun Guo
2013-05-29 11:07 ` Martin Mokrejs
2013-05-30 2:29 ` Hanjun Guo
2013-05-30 13:57 ` Rafael J. Wysocki
2013-05-30 22:25 ` Greg Kroah-Hartman [this message]
2013-05-31 3:58 ` Hanjun Guo
2013-05-31 12:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530222542.GD1630@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmokrejs@fold.natur.cuni.cz \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox