From: Ingo Molnar <mingo@kernel.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: Fix adjust_range_size_mask calling position
Date: Fri, 31 May 2013 13:34:41 +0200 [thread overview]
Message-ID: <20130531113441.GB7131@gmail.com> (raw)
In-Reply-To: <1369861769-30687-1-git-send-email-yinghai@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> Commit 8d57470d cause a kernel panic while setting mem=2G.
> [mem 0x00000000-0x000fffff] page 4k
> [mem 0x7fe00000-0x7fffffff] page 1G
> [mem 0x7c000000-0x7fdfffff] page 1G
> [mem 0x00100000-0x001fffff] page 4k
> [mem 0x00200000-0x7bffffff] page 2M
>
> for last entry is not what we want, we should have
> [mem 0x00200000-0x3fffffff] page 2M
> [mem 0x40000000-0x7bffffff] page 1G
What this changelog does not mention, why does the erroneous entry result
in a kernel panic? It looks like a valid range, so a crash is unexpected.
(This is worth explaining, even if the fix for that is in a separate
patch.)
Thanks,
Ingo
next prev parent reply other threads:[~2013-05-31 11:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 4:30 [PATCH] x86, mm: fix boot hang regression Yuanhan Liu
2013-05-25 7:31 ` Yinghai Lu
2013-05-25 10:25 ` Yuanhan Liu
2013-05-28 23:27 ` Yinghai Lu
2013-05-28 23:28 ` [PATCH] x86: Fix adjust_range_size_mask calling position Yinghai Lu
2013-05-28 23:36 ` H. Peter Anvin
2013-05-28 23:43 ` Yinghai Lu
2013-05-29 2:14 ` H. Peter Anvin
2013-05-29 21:09 ` [PATCH v2] " Yinghai Lu
2013-05-31 11:32 ` Ingo Molnar
2013-05-31 11:34 ` Ingo Molnar [this message]
2013-05-31 15:53 ` [PATCH v3] " Yinghai Lu
2013-05-31 20:18 ` H. Peter Anvin
2013-05-31 20:21 ` H. Peter Anvin
2013-05-31 20:42 ` [tip:x86/urgent] " tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531113441.GB7131@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox