From: Arnd Bergmann <arnd@arndb.de>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Rodolfo Giometti <giometti@enneenne.com>,
Andrew Morton <akpm@linux-foundation.org>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pps-gpio: add device-tree binding and support
Date: Sat, 1 Jun 2013 13:44:35 +0200 [thread overview]
Message-ID: <201306011344.36214.arnd@arndb.de> (raw)
In-Reply-To: <1370083449-11986-1-git-send-email-jlu@pengutronix.de>
On Saturday 01 June 2013, Jan Luebbe wrote:
> Instead of allocating a struct pps_gpio_platform_data in the DT case, store
> the necessary information in struct pps_gpio_device_data itself. This avoids
> an additional allocation and the ifdef. It also gets rid of some indirection.
>
> Also use dev_err instead of pr_err in the changed code.
>
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2013-06-01 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 18:46 [PATCH] pps-gpio: add device-tree binding and support Jan Luebbe
2013-05-31 19:15 ` Arnd Bergmann
2013-06-01 10:44 ` [PATCH v2] " Jan Luebbe
2013-06-01 11:44 ` Arnd Bergmann [this message]
2013-06-03 12:04 ` Rodolfo Giometti
2013-06-03 22:56 ` Andrew Morton
2013-06-03 12:01 ` [PATCH] " Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306011344.36214.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=giometti@enneenne.com \
--cc=grant.likely@linaro.org \
--cc=jlu@pengutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox