public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@canonical.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eCryptfs: Cocci spatch "memdup.spatch"
Date: Sun, 2 Jun 2013 19:47:47 -0700	[thread overview]
Message-ID: <20130603024747.GA10466@boyd> (raw)
In-Reply-To: <1370079576.29224.7.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On 2013-06-01 11:39:36, Thomas Meyer wrote:
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---

Thanks Thomas - I've pushed this to my next branch.

Tyler

> 
> diff -u -p a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
> --- a/fs/ecryptfs/messaging.c
> +++ b/fs/ecryptfs/messaging.c
> @@ -247,14 +247,13 @@ int ecryptfs_process_response(struct ecr
>  		goto unlock;
>  	}
>  	msg_size = (sizeof(*msg) + msg->data_len);
> -	msg_ctx->msg = kmalloc(msg_size, GFP_KERNEL);
> +	msg_ctx->msg = kmemdup(msg, msg_size, GFP_KERNEL);
>  	if (!msg_ctx->msg) {
>  		rc = -ENOMEM;
>  		printk(KERN_ERR "%s: Failed to allocate [%zd] bytes of "
>  		       "GFP_KERNEL memory\n", __func__, msg_size);
>  		goto unlock;
>  	}
> -	memcpy(msg_ctx->msg, msg, msg_size);
>  	msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_DONE;
>  	wake_up_process(msg_ctx->task);
>  	rc = 0;
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2013-06-03  2:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01  9:39 [PATCH] eCryptfs: Cocci spatch "memdup.spatch" Thomas Meyer
2013-06-03  2:47 ` Tyler Hicks [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603024747.GA10466@boyd \
    --to=tyhicks@canonical.com \
    --cc=ecryptfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox