Re: Revert "serial: 8250: Make SERIAL_8250_RUNTIME_UARTS work correctly"

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Jun 03, 2013 at 03:03:10PM -0500, Karthik Manamcheri wrote:
> > No worries, I undertand what Karthik is talking about, so I'll try to
> > figure this out.
> >
> > CONFIG_SERIAL_8250_NR_UARTS=32
> > CONFIG_SERIAL_8250_RUNTIME_UARTS=4
> 
> The description for "CONFIG_SERIAL_8250_RUNTIME_UARTS" is "Set this to the
> maximum number of serial ports you want the kernel to register at boot time."
> Setting it to 4 means that you want to use 4 legacy ports! If you do not have
> any legacy UARTs, you are to set this to 0.
> 
> >
> > is what was set in my .config, resulting in:
> >
> > [3.9.y]
> > 0: uart:16550A port:00001030 irq:16 tx:16522 rx:0 RTS|CTS|DTR|CD
> > 1: uart:unknown port:000002F8 irq:3
> > 2: uart:unknown port:000003E8 irq:4
> > 3: uart:unknown port:000002E8 irq:3
> >
> > [3.10-rc2]
> > 0: uart:unknown port:000003F8 irq:4
> > 1: uart:unknown port:000002F8 irq:3
> > 2: uart:unknown port:000003E8 irq:4
> > 3: uart:unknown port:000002E8 irq:3
> > 4: uart:16550A port:00001030 irq:16 tx:16226 rx:0 RTS|CTS|DTR|CD
> 
> You have five ports because you set CONFIG_SERIAL_8250_RUNTIME_UARTS to 4 and
> then you have to PCI port. This is exactly what my change addressed. We had
> issues with the ghost ports created in the system. In your case, if you set
> CONFIG_SERIAL_8250_RUNTIME_UARTS to 0, you'll have just one port which is the
> working available port.

But it is now named something differently, which is a regression, and we
can't have that, sorry.

thanks,

greg k-h