From: Greg KH <gregkh@linuxfoundation.org>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: Serban Constantinescu <serban.constantinescu@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>,
John Stultz <john.stultz@linaro.org>,
Dave Butcher <Dave.Butcher@arm.com>
Subject: Re: [PATCH v4 3/6] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration
Date: Mon, 3 Jun 2013 15:39:03 -0700 [thread overview]
Message-ID: <20130603223903.GA16711@kroah.com> (raw)
In-Reply-To: <CAMP5XgdHDv_Lr=CXrD51XTrxq1t=16-OK-Q0Ww79wdgm2QXGtA@mail.gmail.com>
On Mon, Jun 03, 2013 at 02:44:25PM -0700, Arve Hjønnevåg wrote:
> On Mon, Jun 3, 2013 at 8:02 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, May 31, 2013 at 04:17:34PM -0700, Arve Hjønnevåg wrote:
> >> On Wed, May 22, 2013 at 3:12 AM, Serban Constantinescu
> >> <serban.constantinescu@arm.com> wrote:
> >> > This change will fix the BINDER_SET_MAX_THREADS ioctl to use __u32
> >> > instead of size_t for setting the max threads. Thus using the same
> >> > handler for 32 and 64bit kernels.
> >> >
> >> > This value is stored internally in struct binder_proc and set to 15
> >> > on open_binder() in the libbinder API(thus no need for a 64bit size_t
> >> > on 64bit platforms).
> >> >
> >> > The change does not affect existing 32bit ABI.
> >> >
> >> > Signed-off-by: Serban Constantinescu <serban.constantinescu@arm.com>
> >> > ---
> >> > drivers/staging/android/binder.h | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
> >> > index 2f94d16..1761541 100644
> >> > --- a/drivers/staging/android/binder.h
> >> > +++ b/drivers/staging/android/binder.h
> >> > @@ -86,7 +86,7 @@ struct binder_version {
> >> >
> >> > #define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)
> >> > #define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)
> >> > -#define BINDER_SET_MAX_THREADS _IOW('b', 5, size_t)
> >> > +#define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32)
> >> > #define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32)
> >> > #define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32)
> >> > #define BINDER_THREAD_EXIT _IOW('b', 8, __s32)
> >> > --
> >> > 1.7.9.5
> >> >
> >>
> >> Acked-by: Arve Hjønnevåg <arve@android.com>
> >
> > What about patches 1 and 2 in this series?
> >
>
> I apparently only responded privately to those. I just resent them.
Thanks for that. I'll wait for the series to be fixed up and resent
before doing anything with them.
greg k-h
next prev parent reply other threads:[~2013-06-03 22:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 10:12 [PATCH v4 0/6] Android Binder IPC Fixes Serban Constantinescu
2013-05-22 10:12 ` [PATCH v4 1/6] staging: android: binder: modify struct binder_write_read to use size_t Serban Constantinescu
2013-06-03 21:42 ` Arve Hjønnevåg
2013-05-22 10:12 ` [PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer Serban Constantinescu
2013-06-03 21:41 ` Arve Hjønnevåg
2013-06-04 8:54 ` Serban Constantinescu
2013-06-04 23:58 ` Arve Hjønnevåg
2013-06-05 8:28 ` Serban Constantinescu
2013-06-18 16:18 ` Serban Constantinescu
2013-05-22 10:12 ` [PATCH v4 3/6] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration Serban Constantinescu
2013-05-31 23:17 ` Arve Hjønnevåg
2013-06-03 15:02 ` Greg KH
2013-06-03 21:44 ` Arve Hjønnevåg
2013-06-03 22:39 ` Greg KH [this message]
2013-05-22 10:12 ` [PATCH v4 4/6] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration Serban Constantinescu
2013-05-22 10:13 ` [PATCH v4 5/6] staging: android: binder: fix alignment issues Serban Constantinescu
2013-05-31 23:18 ` Arve Hjønnevåg
2013-05-22 10:13 ` [PATCH v4 6/6] staging: android: binder: replace types with portable ones Serban Constantinescu
2013-05-31 23:18 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603223903.GA16711@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Dave.Butcher@arm.com \
--cc=arve@android.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serban.constantinescu@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox