Re: [PATCH] dmatest: add ability to disable pq and xor

[Jon Mason <jon.mason@intel.com>]

On Fri, May 31, 2013 at 11:22:10AM +0300, Andy Shevchenko wrote:
> On Fri, May 17, 2013 at 8:54 PM, Jon Mason <jon.mason@intel.com> wrote:
> > dmatest would create a thread to stress XOR and PQ, if the capability is
> > present in the hardware.  Add the ability to disable XOR and PQ by
> > disabling it if *_sources are set to zero.
> 
> Sorry, didn't comment this earlier.
> 
> Those threads are independent including MEMCPY stuff.
> I think it's better to have one additional parameter let's say
> type_of_test where you can set
> 1 for MEMCPY
> 2 for XOR
> 4 for PQ
> 
> Share this parameter via debugfs and use 0x07 as default value.
> I doubt we need this as a module parameter.

This is using the existing module parameter, so there is nothing new
added.  Since the testing is started immediately upon module
insertion, there needs to be a way to prevent it from ever starting.

Thanks,
Jon

> 
> --
> With Best Regards,
> Andy Shevchenko