From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jiang Liu <liuj97@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
Jerome Marchand <jmarchan@redhat.com>,
Yijing Wang <wangyijing@huawei.com>,
devel@driverdev.osuosl.org, Jiang Liu <jiang.liu@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 4/8] zram: destroy all devices on error recovery path in zram_init()
Date: Tue, 4 Jun 2013 11:49:16 +0300 [thread overview]
Message-ID: <20130604084916.GM28112@mwanda> (raw)
In-Reply-To: <1370274140-26420-5-git-send-email-jiang.liu@huawei.com>
Everyone stop putting RFC on their bugfixes! :P No one wants to
pre-review patches.
On Mon, Jun 03, 2013 at 11:42:16PM +0800, Jiang Liu wrote:
> On error recovery path of zram_init(), it leaks the zram device object
> causing the failure.
>
This is a real bug but the fix isn't right. The object causing the
failure has only been partially set up. And in some cases it has
been partially cleaned up, for example we could end up releasing
->queue twice.
The better way is to make create_device() clean up after itself
completely instead of only partly and sometimes.
regards,
dan carpenter
next prev parent reply other threads:[~2013-06-04 8:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 15:42 [RFC PATCH v1 0/8] small bugfixes and code improvements for zram Jiang Liu
2013-06-03 15:42 ` [RFC PATCH v1 1/8] zram: simplify and optimize zram_to_dev() Jiang Liu
2013-06-04 13:09 ` Jerome Marchand
2013-06-04 14:31 ` Jiang Liu
2013-06-03 15:42 ` [RFC PATCH v1 2/8] zram: avoid invalid memory access in zram_exit() Jiang Liu
2013-06-04 9:03 ` Minchan Kim
2013-06-04 14:27 ` Jiang Liu
2013-06-03 15:42 ` [RFC PATCH v1 3/8] zram: use zram->lock to protect zram_free_page() in swap free notify path Jiang Liu
2013-06-03 15:42 ` [RFC PATCH v1 4/8] zram: destroy all devices on error recovery path in zram_init() Jiang Liu
2013-06-04 8:49 ` Dan Carpenter [this message]
2013-06-04 14:57 ` Jiang Liu
2013-06-03 15:42 ` [RFC PATCH v1 5/8] zram: avoid double free in error recovery path of zram_bvec_write() Jiang Liu
2013-06-04 13:27 ` Jerome Marchand
2013-06-03 15:42 ` [RFC PATCH v1 6/8] zram: avoid access beyond the zram device Jiang Liu
2013-06-04 13:15 ` Jerome Marchand
2013-06-04 15:09 ` Jiang Liu
2013-06-05 8:52 ` Jerome Marchand
2013-06-03 15:42 ` [RFC PATCH v1 7/8] zram: optimize memory operations with clear_page()/copy_page() Jiang Liu
2013-06-03 15:42 ` [RFC PATCH v1 8/8] zram: protect sysfs handler from invalid memory access Jiang Liu
2013-06-04 9:00 ` [RFC PATCH v1 0/8] small bugfixes and code improvements for zram Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604084916.GM28112@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@huawei.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox