From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aldo Iljazi <neonsync1@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: anrdroid: sync.c: fixed all checkpatch warnings
Date: Thu, 6 Jun 2013 09:06:28 +0300 [thread overview]
Message-ID: <20130606060628.GZ28112@mwanda> (raw)
In-Reply-To: <1370465159-8609-1-git-send-email-neonsync1@gmail.com>
On Wed, Jun 05, 2013 at 11:45:59PM +0300, Aldo Iljazi wrote:
> Specifically fixed:
> sync.c:128: WARNING: braces {} are not necessary for single statement blocks
> sync.c:879: WARNING: Prefer seq_puts to seq_printf
> sync.c:883: WARNING: Prefer seq_puts to seq_printf
> sync.c:898: WARNING: Prefer seq_puts to seq_printf
> sync.c:902: WARNING: Prefer seq_puts to seq_printf
> sync.c:943: WARNING: Prefer seq_puts to seq_printf
> sync.c:952: WARNING: Prefer seq_puts to seq_printf
> sync.c:956: WARNING: Prefer seq_puts to seq_printf
> sync.c:964: WARNING: Prefer seq_puts to seq_printf
> total: 9 warnings,
>
This breaks the build and it doesn't apply to linux-next. Please
be more careful in the future.
regards,
dan carpenter
prev parent reply other threads:[~2013-06-06 6:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 20:45 [PATCH] Staging: anrdroid: sync.c: fixed all checkpatch warnings Aldo Iljazi
2013-06-06 6:06 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606060628.GZ28112@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neonsync1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox