From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932841Ab3FFLF1 (ORCPT ); Thu, 6 Jun 2013 07:05:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30251 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932321Ab3FFLFX (ORCPT ); Thu, 6 Jun 2013 07:05:23 -0400 Date: Thu, 6 Jun 2013 14:05:50 +0300 From: "Michael S. Tsirkin" To: Jason Wang Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com Subject: Re: [net-next PATCH 8/8] macvtap: enable multiqueue flag Message-ID: <20130606110550.GE8626@redhat.com> References: <1370512480-14272-1-git-send-email-jasowang@redhat.com> <1370512480-14272-9-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370512480-14272-9-git-send-email-jasowang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 06, 2013 at 05:54:40PM +0800, Jason Wang wrote: > To notify the userspace about our capability of multiqueue. > > Signed-off-by: Jason Wang Acked-by: Michael S. Tsirkin > --- > drivers/net/macvtap.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c > index d2d1d55..992151c 100644 > --- a/drivers/net/macvtap.c > +++ b/drivers/net/macvtap.c > @@ -31,10 +31,6 @@ > * macvtap_proto is used to allocate queues through the sock allocation > * mechanism. > * > - * TODO: multiqueue support is currently not implemented, even though > - * macvtap is basically prepared for that. We will need to add this > - * here as well as in virtio-net and qemu to get line rate on 10gbit > - * adapters from a guest. > */ > struct macvtap_queue { > struct sock sk; > @@ -1027,7 +1023,8 @@ static long macvtap_ioctl(struct file *file, unsigned int cmd, > return macvtap_ioctl_set_queue(file, u); > > case TUNGETFEATURES: > - if (put_user(IFF_TAP | IFF_NO_PI | IFF_VNET_HDR, up)) > + if (put_user(IFF_TAP | IFF_NO_PI | IFF_VNET_HDR | > + IFF_MULTI_QUEUE, up)) > return -EFAULT; > return 0; > > -- > 1.7.1